Skip to content

Commit 6516e15

Browse files
authored
Changes frozen to waiting (#1551)
* Offset the tooltip in more * The Select component’s shortcut has a better hover state * “Frozen” changed to “Waiting”
1 parent 7f2365f commit 6516e15

File tree

5 files changed

+33
-31
lines changed

5 files changed

+33
-31
lines changed

apps/webapp/app/components/primitives/Select.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,11 @@ export function SelectItem({
482482
<div className="grow truncate">{props.children || props.value}</div>
483483
{checkIcon}
484484
{shortcut && (
485-
<ShortcutKey className={cn("size-4 flex-none")} shortcut={shortcut} variant={"small"} />
485+
<ShortcutKey
486+
className={cn("size-4 flex-none transition duration-0 group-hover:border-charcoal-600")}
487+
shortcut={shortcut}
488+
variant={"small"}
489+
/>
486490
)}
487491
</div>
488492
</Ariakit.SelectItem>

apps/webapp/app/components/runs/v3/RunFilters.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ function StatusDropdown({
356356
<TooltipTrigger className="group flex w-full flex-col py-0">
357357
<TaskRunStatusCombo status={item.value} iconClassName="animate-none" />
358358
</TooltipTrigger>
359-
<TooltipContent side="right" sideOffset={9}>
359+
<TooltipContent side="right" sideOffset={50}>
360360
<Paragraph variant="extra-small">
361361
{descriptionForTaskRunStatus(item.value)}
362362
</Paragraph>

apps/webapp/app/components/runs/v3/TaskRunAttemptStatus.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@ import {
22
CheckCircleIcon,
33
ClockIcon,
44
NoSymbolIcon,
5-
PauseCircleIcon,
65
RectangleStackIcon,
76
XCircleIcon,
87
} from "@heroicons/react/20/solid";
98
import type { TaskRunAttemptStatus as TaskRunAttemptStatusType } from "@trigger.dev/database";
10-
import { TaskRunAttemptStatus } from "~/database-types";
119
import assertNever from "assert-never";
12-
import { SnowflakeIcon } from "lucide-react";
10+
import { HourglassIcon, SnowflakeIcon } from "lucide-react";
1311
import { Spinner } from "~/components/primitives/Spinner";
12+
import { TaskRunAttemptStatus } from "~/database-types";
1413
import { cn } from "~/utils/cn";
1514

1615
export const allTaskRunAttemptStatuses = Object.values(
@@ -65,7 +64,7 @@ export function TaskRunAttemptStatusIcon({
6564
case "EXECUTING":
6665
return <Spinner className={cn(runAttemptStatusClassNameColor(status), className)} />;
6766
case "PAUSED":
68-
return <SnowflakeIcon className={cn(runAttemptStatusClassNameColor(status), className)} />;
67+
return <HourglassIcon className={cn(runAttemptStatusClassNameColor(status), className)} />;
6968
case "FAILED":
7069
return <XCircleIcon className={cn(runAttemptStatusClassNameColor(status), className)} />;
7170
case "CANCELED":
@@ -91,7 +90,7 @@ export function runAttemptStatusClassNameColor(status: ExtendedTaskAttemptStatus
9190
case "EXECUTING":
9291
return "text-pending";
9392
case "PAUSED":
94-
return "text-sky-300";
93+
return "text-charcoal-500";
9594
case "FAILED":
9695
return "text-error";
9796
case "CANCELED":
@@ -117,7 +116,7 @@ export function runAttemptStatusTitle(status: ExtendedTaskAttemptStatus | null):
117116
case "EXECUTING":
118117
return "Executing";
119118
case "PAUSED":
120-
return "Frozen";
119+
return "Waiting";
121120
case "FAILED":
122121
return "Failed";
123122
case "CANCELED":

apps/webapp/app/components/runs/v3/TaskRunStatus.tsx

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@ import {
88
NoSymbolIcon,
99
PauseCircleIcon,
1010
RectangleStackIcon,
11-
StopIcon,
1211
TrashIcon,
1312
XCircleIcon,
1413
} from "@heroicons/react/20/solid";
1514
import { TaskRunStatus } from "@trigger.dev/database";
1615
import assertNever from "assert-never";
17-
import { SnowflakeIcon } from "lucide-react";
16+
import { HourglassIcon } from "lucide-react";
1817
import { TimedOutIcon } from "~/assets/icons/TimedOutIcon";
1918
import { Spinner } from "~/components/primitives/Spinner";
2019
import { cn } from "~/utils/cn";
@@ -41,9 +40,9 @@ export const filterableTaskRunStatuses = [
4140
"WAITING_FOR_DEPLOY",
4241
"DELAYED",
4342
"PENDING",
43+
"WAITING_TO_RESUME",
4444
"EXECUTING",
4545
"RETRYING_AFTER_FAILURE",
46-
"WAITING_TO_RESUME",
4746
"COMPLETED_SUCCESSFULLY",
4847
"CANCELED",
4948
"COMPLETED_WITH_ERRORS",
@@ -55,21 +54,21 @@ export const filterableTaskRunStatuses = [
5554
] as const satisfies Readonly<Array<TaskRunStatus>>;
5655

5756
const taskRunStatusDescriptions: Record<TaskRunStatus, string> = {
58-
DELAYED: "Task has been delayed and is waiting to be executed",
59-
PENDING: "Task is waiting to be executed",
60-
WAITING_FOR_DEPLOY: "Task needs to be deployed first to start executing",
61-
EXECUTING: "Task is currently being executed",
62-
RETRYING_AFTER_FAILURE: "Task is being reattempted after a failure",
63-
WAITING_TO_RESUME: "Task has been frozen and is waiting to be resumed",
64-
COMPLETED_SUCCESSFULLY: "Task has been successfully completed",
65-
CANCELED: "Task has been canceled",
66-
COMPLETED_WITH_ERRORS: "Task has failed with errors",
67-
INTERRUPTED: "Task has failed because it was interrupted",
68-
SYSTEM_FAILURE: "Task has failed due to a system failure",
69-
PAUSED: "Task has been paused by the user",
70-
CRASHED: "Task has crashed and won't be retried",
71-
EXPIRED: "Task has surpassed its ttl and won't be executed",
72-
TIMED_OUT: "Task has failed because it exceeded its maxDuration",
57+
DELAYED: "Task has been delayed and is waiting to be executed.",
58+
PENDING: "Task is waiting to be executed.",
59+
WAITING_FOR_DEPLOY: "Task needs to be deployed first to start executing.",
60+
EXECUTING: "Task is currently being executed.",
61+
RETRYING_AFTER_FAILURE: "Task is being reattempted after a failure.",
62+
WAITING_TO_RESUME: `You have used a "wait" function. When the wait is complete, the task will resume execution.`,
63+
COMPLETED_SUCCESSFULLY: "Task has been successfully completed.",
64+
CANCELED: "Task has been canceled.",
65+
COMPLETED_WITH_ERRORS: "Task has failed with errors.",
66+
INTERRUPTED: "Task has failed because it was interrupted.",
67+
SYSTEM_FAILURE: "Task has failed due to a system failure.",
68+
PAUSED: "Task has been paused by the user.",
69+
CRASHED: "Task has crashed and won't be retried.",
70+
EXPIRED: "Task has surpassed its ttl and won't be executed.",
71+
TIMED_OUT: "Task has failed because it exceeded its maxDuration.",
7372
};
7473

7574
export const QUEUED_STATUSES = [
@@ -126,7 +125,7 @@ export function TaskRunStatusIcon({
126125
case "EXECUTING":
127126
return <Spinner className={cn(runStatusClassNameColor(status), className)} />;
128127
case "WAITING_TO_RESUME":
129-
return <SnowflakeIcon className={cn(runStatusClassNameColor(status), className)} />;
128+
return <HourglassIcon className={cn(runStatusClassNameColor(status), className)} />;
130129
case "RETRYING_AFTER_FAILURE":
131130
return <ArrowPathIcon className={cn(runStatusClassNameColor(status), className)} />;
132131
case "PAUSED":
@@ -165,7 +164,7 @@ export function runStatusClassNameColor(status: TaskRunStatus): string {
165164
case "RETRYING_AFTER_FAILURE":
166165
return "text-pending";
167166
case "WAITING_TO_RESUME":
168-
return "text-sky-300";
167+
return "text-charcoal-500";
169168
case "PAUSED":
170169
return "text-amber-300";
171170
case "CANCELED":
@@ -200,7 +199,7 @@ export function runStatusTitle(status: TaskRunStatus): string {
200199
case "EXECUTING":
201200
return "Executing";
202201
case "WAITING_TO_RESUME":
203-
return "Frozen";
202+
return "Waiting";
204203
case "RETRYING_AFTER_FAILURE":
205204
return "Reattempting";
206205
case "PAUSED":

docs/runs.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ currently running.
4242
<Icon icon="arrows-rotate" iconType="solid" color="#3B82F6" size={17} /> **Reattempting**: The task has
4343
failed and is being retried.
4444

45-
<Icon icon="snowflake" iconType="solid" color="#68BAF2" size={17} /> **Frozen**: Task has been frozen
46-
and is waiting to be resumed.
45+
<Icon icon="hourglass" iconType="solid" color="#878C99" size={17} /> **Waiting**: You have used a
46+
[triggerAndWait()](/triggering#yourtask-triggerandwait), [batchTriggerAndWait()](/triggering#yourtask-batchtriggerandwait) or a [wait function](/wait). When the wait is complete, the task will resume execution.
4747

4848
### Final States
4949

0 commit comments

Comments
 (0)