tests: fix lint, format tests; update devcontainer Makefile and test fixtures

Author: ilude

.coverage.onboard.7111.XFXYSZwx

@@ -33,7 +33,16 @@ test: uv.lock
 		echo "behave not installed in uv environment, skipping BDD tests"; \
 	fi
 	@echo "Running ALL tests (excluding disabled tests)..."
-	uv run --all-packages pytest tests/ --ignore=tests/support --cov=app --cov-report=term-missing --cov-report=html:.htmlcov -v
+	# Run pytest but explicitly exclude integration tests during the regular test run
+	uv run --all-packages pytest tests/ --ignore=tests/support --ignore=tests/integration \
+		--cov=app --cov-report=term-missing --cov-report=html:.htmlcov -v
+
+# Run full test suite including integration tests. This target depends on the
+# regular 'test' target so unit/BDD tests run first, then integration tests run
+# afterwards.
+test-integration: test
+	@echo "Running integration tests..."
+	uv run --all-packages pytest tests/integration --cov=app --cov-report=term-missing -v
 
 # Run linting
 # E203: whitespace before ':' (conflicts with black formatting)

.devcontainer/Makefile

@@ -20,7 +20,7 @@
     }
   },
   "initializeCommand": "make initialize",
-  "postCreateCommand": "chown -R ${USER}:${USER} ${PROJECT_PATH} && uv sync --dev && ./.devcontainer/setup-dotfiles.sh",
+  "postCreateCommand": "sudo chown -R ${USER}:${USER} ${PROJECT_PATH} && uv sync --dev && ./.devcontainer/setup-dotfiles.sh",
   "runArgs": [
     "--name","${localWorkspaceFolderBasename}_devcontainer",
     "--hostname","${localWorkspaceFolderBasename}",

.devcontainer/devcontainer.json

@@ -93,6 +93,12 @@ if [ "$(id -u)" = "0" ]; then
 
     echo "Running as user ${USER}: $@"
     exec gosu ${USER} "$@"
+    else
+        # If not running as root, attempt to chown docker.sock using sudo if available
+        if command -v sudo >/dev/null 2>&1; then
+            sudo chown ${USER}:${USER} /var/run/docker.sock >/dev/null 2>&1 || true
+            sudo chown -R ${USER}:${USER} ${HOME}
+        fi
 fi
 
 echo "Running: $@"
@@ -235,7 +241,8 @@ RUN --mount=type=cache,target=/var/cache/apt \
 RUN --mount=type=cache,target=/tmp/.cache/uv \
     --mount=type=cache,target=/root/.cache/pip \
     --mount=type=cache,target=/root/.cache/uv \
-    uv sync --dev
+    uv sync --dev && \
+    chown -R $USER:$USER /usr/local/lib/python3.12/site-packages/
 
 # Copy application code after dependency installation (keep package layout)
 COPY --chown=${USER}:${USER} app ${PROJECT_PATH}/

Dockerfile

@@ -3,15 +3,15 @@
 
 
 def is_test_environment() -> bool:
-  """Centralized detection for test environments.
+    """Centralized detection for test environments.
 
-  This function consolidates the heuristic used across the app for
-  skipping scheduler startup and other test-only behavior.
-  """
-  return (
-      os.environ.get("ONBOARD_DISABLE_SCHEDULER", "False").lower() == "true"
-      or "pytest" in sys.modules
-      or "PYTEST_CURRENT_TEST" in os.environ
-      or any("test" in arg for arg in sys.argv)
-      or "behave" in sys.modules
-  )
+    This function consolidates the heuristic used across the app for
+    skipping scheduler startup and other test-only behavior.
+    """
+    return (
+        os.environ.get("ONBOARD_DISABLE_SCHEDULER", "False").lower() == "true"
+        or "pytest" in sys.modules
+        or "PYTEST_CURRENT_TEST" in os.environ
+        or any("test" in arg for arg in sys.argv)
+        or "behave" in sys.modules
+    )

app/modules/testsupport.py

@@ -52,7 +52,7 @@ def register(self, name, bundle):
 
     fake_flask_assets.Bundle = FakeBundle
     fake_flask_assets.Environment = FakeEnvironment
-    sys.modules["flask_assets"] = fake_flask_assets
+    monkeypatch.setitem(sys.modules, "flask_assets", fake_flask_assets)
 
     # Execute the module as __main__ to run top-level code; it will import our fake
     try:
@@ -112,7 +112,7 @@ def register(self, name, bundle):
 
     fake_flask_assets.Bundle = FakeBundle
     fake_flask_assets.Environment = FakeEnvironment
-    sys.modules["flask_assets"] = fake_flask_assets
+    monkeypatch.setitem(sys.modules, "flask_assets", fake_flask_assets)
 
     try:
         sys.modules.pop("app.main", None)
@@ -148,8 +148,8 @@ def fake_serve(*a, **kw):
         return "SENTINEL"
 
     fake_asyncio.serve = fake_serve
-    sys.modules["hypercorn"] = fake_hypercorn_mod
-    sys.modules["hypercorn.asyncio"] = fake_asyncio
+    monkeypatch.setitem(sys.modules, "hypercorn", fake_hypercorn_mod)
+    monkeypatch.setitem(sys.modules, "hypercorn.asyncio", fake_asyncio)
 
     # Provide a fake Config class expected by the module
     fake_config_mod = types.ModuleType("hypercorn.config")
@@ -158,7 +158,7 @@ class FakeConfig:
         pass
 
     fake_config_mod.Config = FakeConfig
-    sys.modules["hypercorn.config"] = fake_config_mod
+    monkeypatch.setitem(sys.modules, "hypercorn.config", fake_config_mod)
 
     # Fake event loop with add_signal_handler and run_until_complete
     class FakeLoop:
@@ -200,7 +200,7 @@ def register(self, name, bundle):
 
     fake_flask_assets.Bundle = FakeBundle
     fake_flask_assets.Environment = FakeEnvironment
-    sys.modules["flask_assets"] = fake_flask_assets
+    monkeypatch.setitem(sys.modules, "flask_assets", fake_flask_assets)
 
     try:
         sys.modules.pop("app.main", None)