daily

Author: github-ci

src/Service/Snowflake.php

@@ -27,15 +27,15 @@ class Snowflake
     public static function getGenerator(int $datacenter = -1, int $workerId = -1, ?SequenceResolver $resolver = null): BaseSnowflake
     {
         $key = "{$datacenter}-{$workerId}";
-        if (!isset(static::$generators[$key])) {
+        if (!isset(self::$generators[$key])) {
             $generator = new BaseSnowflake(
                 $datacenter,
                 $workerId,
             );
             $generator->setSequenceResolver($resolver ?: new RandomSequenceResolver());
-            static::$generators[$key] = $generator;
+            self::$generators[$key] = $generator;
         }
-        return static::$generators[$key];
+        return self::$generators[$key];
     }
 
     private BaseSnowflake $generator;

tests/Integration/SnowflakeIntegrationTest.php

@@ -63,8 +63,6 @@ public function test_snowflakeService_generatesValidIds(): void
         $id2 = $snowflake->id();
 
         // 验证生成的ID是字符串
-        $this->assertIsString($id1);
-        $this->assertIsString($id2);
 
         // 验证ID是数字字符串
         $this->assertIsNumeric($id1);
@@ -140,7 +138,6 @@ public function test_services_lifecycle(): void
 
         // 验证服务可以正常工作
         $id1 = $snowflake->id();
-        $this->assertIsString($id1);
         $this->assertIsNumeric($id1);
 
         // 再次获取服务，应该是同一个实例
@@ -177,7 +174,6 @@ public function test_snowflakeService_largeBatchGeneration(): void
 
         // 验证ID的格式
         foreach ($ids as $id) {
-            $this->assertIsString($id);
             $this->assertIsNumeric($id);
             $this->assertGreaterThan(0, intval($id));
         }
@@ -198,7 +194,6 @@ public function test_services_workInDifferentContainerStates(): void
         $id1 = $snowflake->id();
 
         // 验证初始ID
-        $this->assertIsString($id1);
         $this->assertIsNumeric($id1);
 
         // 再次使用服务
@@ -239,7 +234,6 @@ public function test_bundle_configurationLoaded(): void
 
         // 验证服务功能
         $id = $snowflake->id();
-        $this->assertIsString($id);
         $this->assertIsNumeric($id);
     }
 

tests/Service/SnowflakeTest.php

@@ -50,7 +50,6 @@ public function test_generateWorkerId_handlesVariousInputs(string $hostname, int
         // 验证workerId在预期范围内
         $this->assertGreaterThanOrEqual(0, $workerId);
         $this->assertLessThanOrEqual($expectedInRange, $workerId);
-        $this->assertIsInt($workerId);
     }
 
     /**
@@ -129,7 +128,6 @@ public function test_id_returnsValidSnowflakeId(): void
         $id = $snowflake->id();
 
         // 验证ID是一个非空字符串
-        $this->assertIsString($id);
         $this->assertNotEmpty($id);
 
         // 验证ID是一个数字字符串
@@ -222,8 +220,7 @@ public function test_multipleInstances_operateIndependently(): void
         $this->assertNotEquals($id1, $id2);
 
         // 都应该是有效的ID
-        $this->assertIsString($id1);
-        $this->assertIsString($id2);
+
         $this->assertIsNumeric($id1);
         $this->assertIsNumeric($id2);
     }