Skip to content

Commit 9ed9ae9

Browse files
committed
#88 add test scenario
1 parent b91a252 commit 9ed9ae9

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

DeviceDetector.NET.Tests/DeviceDetectorTest.cs

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
using System;
1111
using System.Collections.Generic;
1212
using System.Threading.Tasks;
13+
using DeviceDetectorNET.Results.Client;
1314
using Xunit;
1415

1516
namespace DeviceDetectorNET.Tests;
@@ -788,4 +789,39 @@ public void TestIssue22_Test3()
788789
dd.Match.OsFamily.Should().Be("Mac");
789790
dd.Match.DeviceType.Should().Be("desktop");
790791
}
792+
793+
/// <summary>
794+
/// Issue #88
795+
/// </summary>
796+
[Fact]
797+
public void TestIssue88_Test1()
798+
{
799+
const string userAgent = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36";
800+
var dd = DeviceDetector.GetInfoFromUserAgent(userAgent);
801+
dd.Success.Should().BeTrue();
802+
var browserMatch = dd.Match.Client as BrowserMatchResult;
803+
browserMatch.Should().Be("Chrome");
804+
browserMatch.Should().Be("131.0.0.0");
805+
browserMatch.EngineVersion.Should().Be("Blink");
806+
807+
}
808+
/// <summary>
809+
/// Issue #88
810+
/// </summary>
811+
[Fact]
812+
public void TestIssue88_Test2()
813+
{
814+
var clientHints = ClientHints.Factory(new Dictionary<string, string>
815+
{
816+
["sec-ch-ua"] = "\"Google Chrome\";v=\"131\", \"Chromium\";v=\"131\", \"Not_A Brand\";v=\"24\"",
817+
});
818+
const string userAgent = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36";
819+
var dd = DeviceDetector.GetInfoFromUserAgent(userAgent, clientHints);
820+
dd.Success.Should().BeTrue();
821+
var browserMatch = dd.Match.Client as BrowserMatchResult;
822+
browserMatch.Should().Be("360 Secure Browser");
823+
browserMatch.Should().Be("131.0.0.0");
824+
browserMatch.EngineVersion.Should().Be("Blink");
825+
826+
}
791827
}

DeviceDetector.NET/DeviceDetector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ protected void ParseDevice()
672672
osVersion = os.Match.Version;
673673
if (!string.IsNullOrEmpty(osVersion))
674674
{
675-
osVersion = !osVersion.Contains(".") ? osVersion + ".0" : osVersion;
675+
osVersion = !osVersion.Contains('.') ? osVersion + ".0" : osVersion;
676676
}
677677
}
678678

0 commit comments

Comments
 (0)