Fixed incorrect handling of Spin2 ^x parameters

Author: totalspectrum

Changelog.txt

@@ -1,6 +1,7 @@
 Version 7.3.1
 - Fixed some errors in C __pasm parsing
 - Fixed compile time calculations of QLOG and QEXP (thanks to Ada)
+- Fixed many incorrect address calculations for Spin2 ^x variables
 
 Version 7.3.0
 - Allow `__attribute__((packed))` on C structs

frontends/spin/spinlang.c

@@ -213,8 +213,9 @@ TransformLongMove(AST **astptr, AST *ast)
 
 //
 // fix up any parameters passed by reference
-// this applies both to calls into BASIC/C++ functions, but
-// also ^Struct parameters in Spin2
+// this applies both to calls into BASIC/C++ functions
+// but not to ^Struct parameters, which are more like
+// pointer types
 //
 static void
 FixupSpinParameterTypes(AST **astptr, AST *ast)

frontends/types.c

@@ -1324,7 +1324,8 @@ AST *CoerceAssignTypes(AST *line, int kind, AST **astptr, AST *desttype, AST *sr
         }
     }
     AstReportAs(expr, &saveinfo);
-    if (IsRefType(desttype) && (kind == AST_FUNCCALL || kind == AST_RETURN)) {
+    if (IsRefType(desttype) && (kind == AST_FUNCCALL || kind == AST_RETURN)
+        && !IsSpinLang(lang)) {
         // passing or returning reference parameter
         if (!astptr) {
             ERROR(line, "Unable to pass or return multiple function result to reference parameter");