Skip to content

Commit 3142fc4

Browse files
authored
Merge pull request #250 from topolvm/fix-setup-envtest
pin setup-envtest to go 1.20
2 parents 5c8e347 + fce1457 commit 3142fc4

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ SETUP_ENVTEST := $(BINDIR)/setup-envtest
147147
setup-envtest: $(SETUP_ENVTEST) ## Download setup-envtest locally if necessary
148148
$(SETUP_ENVTEST):
149149
# see https://github.com/kubernetes-sigs/controller-runtime/tree/master/tools/setup-envtest
150-
GOBIN=$(BINDIR) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
150+
GOBIN=$(BINDIR) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION)
151151

152152
.PHONY: setup
153153
setup: # Setup tools

versions.mk

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ KUBE_PROMETHEUS_VERSION := 0.13.0
1414
KUBERNETES_VERSION ?= 1.28.0
1515
TOPOLVM_VERSION := topolvm-chart-v14.0.0
1616

17+
# ENVTEST_VERSION is usually latest, but might need to be pinned from time to time.
18+
# Version pinning is needed due to version incompatibility between controller-runtime and setup-envtest.
19+
# For more information: https://github.com/kubernetes-sigs/controller-runtime/issues/2744
20+
ENVTEST_VERSION := bf15e44028f908c790721fc8fe67c7bf2d06a611
21+
1722
ENVTEST_K8S_VERSION := $(shell echo $(KUBERNETES_VERSION) | cut -d "." -f 1-2)
1823

1924
# Tools versions which are defined in go.mod

0 commit comments

Comments
 (0)