Skip to content

Commit 48f4fb6

Browse files
authored
Cleans up class as well as updates readme (#32)
1 parent 3b18308 commit 48f4fb6

File tree

3 files changed

+20
-4
lines changed

3 files changed

+20
-4
lines changed

README.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,25 @@ ad_set.destroy
341341

342342
___
343343

344+
### [Ad Set Activities](https://developers.facebook.com/docs/marketing-api/reference/ad-activity) (Fetch)
345+
346+
You interact with activities via an ad set:
347+
```ruby
348+
ad_set = account.ad_sets(effective_status: nil).first
349+
```
350+
351+
Fetch all activities in last 24 hours for an ad set:
352+
```ruby
353+
activities = ad_set.activities
354+
```
355+
356+
Fetch all activities in last 48 hours for an ad set:
357+
```ruby
358+
activities = ad_set.activities(since: 2.days.ago)
359+
```
360+
361+
___
362+
344363
### [Ads](https://developers.facebook.com/docs/marketing-api/reference/adgroup) (Fetch, Find, Create, Update, Destroy)
345364

346365
You interact with ads via an ad set:

lib/facebook_ads/ad_set.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def ad_insights(range: Date.today..Date.today, level: nil, breakdowns: [], field
110110
end
111111

112112
# Retrieves activities for ad set (in last 24 hours by default)
113-
def activities(since = 1.day.ago)
113+
def activities(since: 1.day.ago)
114114
AdSetActivity.get("/#{id}/activities", objectify: true).select { |activity| activity['event_time'] > since }
115115
end
116116
end

lib/facebook_ads/ad_set_activity.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
module FacebookAds
44
# https://developers.facebook.com/docs/marketing-api/reference/ad-activity/
5-
# curl -G
6-
# -d 'fields=actor_id,actor_name,event_time,event_type,extra_data,translated_event_type'
7-
# -d 'access_token=<access_token>' https://graph.facebook.com/v3.1/<ad_set_id>/activities
85
class AdSetActivity < Base
96
FIELDS = %w[
107
actor_id

0 commit comments

Comments
 (0)