Skip to content

Commit 11f57f0

Browse files
committed
Fixed errors in javadocs
1 parent 18b42d8 commit 11f57f0

File tree

10 files changed

+23
-16
lines changed

10 files changed

+23
-16
lines changed

src/main/java/sk/tomsik68/mclauncher/api/login/IProfile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package sk.tomsik68.mclauncher.api.login;
22

33
/**
4-
* Represents a profile - saved username & password
4+
* Represents a profile - saved username and password
55
*
66
* @author Tomsik68
77
*/

src/main/java/sk/tomsik68/mclauncher/api/login/IProfileIO.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package sk.tomsik68.mclauncher.api.login;
22

33
/**
4-
* ProfileIO can read & write profiles. One IO can contain more profiles.
4+
* ProfileIO can read and write profiles. One IO can contain more profiles.
55
*
66
* @author Tomsik68
77
*/

src/main/java/sk/tomsik68/mclauncher/api/mods/IModdingProfile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public interface IModdingProfile {
4444
/**
4545
* Minecraft arguments are arguments that will be available in minecraft's main method.
4646
* These contain mostly user information, but also assets path, saves path etc, which might be useful...
47-
* @param minecraftArguments
47+
* @param minecraftArguments Array of minecraft arguments created by launcher
4848
* @return Array of string which is formatted in the same way as the input array. If you don't want to make any changes, return null or <code>minecraftArguments</code>
4949
*/
5050
public String[] changeMinecraftArguments(String[] minecraftArguments);

src/main/java/sk/tomsik68/mclauncher/api/servers/FoundServerInfoBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public final FoundServerInfoBuilder port(int p){
3434
/**
3535
*
3636
* @param ico - Icon image encoded as base64 string
37-
* @return
37+
* @return <code>this</code> for chaining
3838
*/
3939
public final FoundServerInfoBuilder icon(String ico){
4040
icon = ico;

src/main/java/sk/tomsik68/mclauncher/api/services/IOnlineService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88
public interface IOnlineService {
99
/**
10-
* @param availability
10+
* @param availability - Availability object retrieved from central server
1111
* @return True if this service is available. The result is to be determined using availability specified
1212
*/
1313
public boolean isAvailable(IServicesAvailability availability);

src/main/java/sk/tomsik68/mclauncher/api/ui/IProgressMonitor.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@
99
*/
1010
public interface IProgressMonitor {
1111
/**
12-
* Sets current progress
12+
* Sets current progress. <B>Please note this value is between 0 and max_progress.
13+
* You need to scale it yourself in order to get progress information between 0 and 100.</B>
1314
*
1415
* @param progress New progress value
16+
* @see IProgressMonitor#setMax(int)
1517
*/
1618
public void setProgress(int progress);
1719

@@ -25,7 +27,7 @@ public interface IProgressMonitor {
2527
/**
2628
* Increments current progress value by <code>amount</code>
2729
*
28-
* @param amount
30+
* @param amount How much
2931
*/
3032
public void incrementProgress(int amount);
3133

src/main/java/sk/tomsik68/mclauncher/api/versions/IVersionList.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,16 @@ public interface IVersionList extends IObservable<String> {
1818

1919
/**
2020
* Retrieves IVersion object with this ID
21-
* @param id
21+
* @param id ID of version to retrieve (e.g. "1.8")
2222
* @return IVersion object for the passed ID
23-
* @throws Exception
23+
* @throws Exception - Network errors, JSON parsing errors, version inheritance problems
2424
*/
2525
public IVersion retrieveVersionInfo(String id) throws Exception;
2626

2727
/**
2828
*
2929
* @return LatestVersionInformation object
30-
* @throws Exception
30+
* @throws Exception - Network errors, JSON parsing errors
3131
*/
3232
public LatestVersionInformation getLatestVersionInformation() throws Exception;
3333
}

src/main/java/sk/tomsik68/mclauncher/backend/MinecraftLauncherBackend.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public List<String> getVersionList() throws Exception {
4848
* This should be run everytime before you launch.
4949
* @param versionID - ID of version to check for update.
5050
* @param progress - {@link IProgressMonitor} in case you want to track the update progress. It may be null
51-
* @throws Exception
51+
* @throws Exception - Network errors, JSON parsing
5252
*/
5353
public void updateMinecraft(String versionID, IProgressMonitor progress) throws Exception {
5454
if (versionID == null || versionID.length() == 0) throw new NullPointerException("versionID can't be null!");
@@ -61,7 +61,7 @@ public void updateMinecraft(String versionID, IProgressMonitor progress) throws
6161
* @param session - Authentication session
6262
* @param versionID - Version ID to run
6363
* @return ProcessBuilder which has minecraft command inside of it. No other things are setup.
64-
* @throws Exception
64+
* @throws Exception - Network errors, JSON parsing, process failures
6565
*/
6666
public ProcessBuilder launchMinecraft(ISession session, String versionID) throws Exception {
6767
return launchMinecraft(session, null, versionID, DEFAULT_LAUNCH_SETTINGS, null);
@@ -75,7 +75,7 @@ public ProcessBuilder launchMinecraft(ISession session, String versionID) throws
7575
* @param launchSettings - Launch settings(amount of RAM etc)
7676
* @param moddingProfile - Modding profile information(overriding game jar etc.). May be null.
7777
* @return ProcessBuilder which has minecraft command inside of it. No other things are setup.
78-
* @throws Exception
78+
* @throws Exception - Network errors, JSON parsing, process failures
7979
*/
8080
public ProcessBuilder launchMinecraft(ISession session, ServerInfo serverInfo, String versionID, ILaunchSettings launchSettings, IModdingProfile moddingProfile) throws Exception {
8181
if(versionID == null || versionID.length() == 0) throw new NullPointerException("versionID can't be null!");

src/main/java/sk/tomsik68/mclauncher/impl/common/Platform.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ public final class Platform {
2525
/** our current operating system */
2626
private static IOperatingSystem currentOS = null;
2727

28-
/** tries to determine the current operating system */
28+
/** tries to determine the current operating system
29+
* @return Current operating system
30+
* */
2931
public static IOperatingSystem getCurrentPlatform() {
3032
if (currentOS != null)
3133
return currentOS;
@@ -39,7 +41,10 @@ public static IOperatingSystem getCurrentPlatform() {
3941
return currentOS;
4042
}
4143

42-
/** forces current operating system */
44+
/** Forces current operating system. This can be used to override the default setting
45+
* in case OS detection goes wrong(it doesn't go wrong very often) or for testing.
46+
* @param p - The operating system we want to use
47+
* */
4348
public static void forcePlatform(IOperatingSystem p) {
4449
MCLauncherAPI.log.fine("Current platform: ".concat(p.getDisplayName()));
4550
currentOS = p;

src/main/java/sk/tomsik68/mclauncher/util/HttpUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public static String httpGet(String url) throws Exception {
3939
* Execute a secured POST request
4040
* @param url URL to request
4141
* @param keyInput the secret key to be used
42-
* @param parameters Parameters in form <code>name=Tom&password=pass123</code>. They needn't to be URL-encoded(it will be done automatically)
42+
* @param parameters Parameters in form <code>name=Tom&amp;password=pass123</code>. They needn't to be URL-encoded(it will be done automatically)
4343
* @return The result of request
4444
* @throws Exception I/O Exception, HTTP errors or invalid key
4545
*/

0 commit comments

Comments
 (0)