[ksqlDB.RestApi.Client]: fixed creation of multiple FieldMetadata for primitive field in Base class unit test #102

Author: tomasfabian

ksqlDb.RestApi.Client/FluentAPI/Builders/EntityTypeBuilder.cs

@@ -57,11 +57,7 @@ public IFieldTypeBuilder<TProperty> Property<TProperty>(Expression<Func<TEntity,
       string path = string.Empty;
       foreach (var (memberName, memberInfo) in members)
       {
-        var memberInfoKey = new MemberInfoKey
-        {
-          Module = memberInfo.Module,
-          MetadataToken = memberInfo.MetadataToken
-        };
+        var memberInfoKey = memberInfo.ToMemberInfoKey();
         path += memberName;
 
         if (!Metadata.FieldsMetadataDict.TryGetValue(memberInfoKey, out var fieldMetadata))
@@ -127,11 +123,7 @@ internal void IgnoreRowTime()
 
     private void AddFieldMetadata(MemberInfo memberInfo, bool ignoreInDDL)
     {
-      var memberInfoKey = new MemberInfoKey
-      {
-        Module = memberInfo.Module,
-        MetadataToken = memberInfo.MetadataToken
-      };
+      var memberInfoKey = memberInfo.ToMemberInfoKey();
 
       var fieldMetadata = new FieldMetadata
       {

ksqlDb.RestApi.Client/FluentAPI/Builders/MemberInfoKey.cs

@@ -1,10 +1,20 @@
 using System.Reflection;
 
-namespace ksqlDb.RestApi.Client.FluentAPI.Builders
+namespace ksqlDb.RestApi.Client.FluentAPI.Builders;
+internal record MemberInfoKey
 {
-  internal record MemberInfoKey
+  internal Module Module { get; set; }
+  internal int MetadataToken { get; set; }
+}
+
+internal static class MemberInfoExtensions
+{
+  internal static MemberInfoKey ToMemberInfoKey(this MemberInfo memberInfo)
   {
-    internal Module Module { get; set; }
-    internal int MetadataToken { get; set; }
+    return new MemberInfoKey
+    {
+      Module = memberInfo.Module,
+      MetadataToken = memberInfo.MetadataToken
+    };
   }
 }