Skip to content

Commit fd23762

Browse files
committed
removing email requirement
1 parent a52021c commit fd23762

File tree

8 files changed

+7
-142
lines changed

8 files changed

+7
-142
lines changed

README.md

Lines changed: 5 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,8 @@
2222
- Module tested for Terraform 0.14.
2323
- AWS provider version [3.29.0](https://registry.terraform.io/providers/hashicorp/aws/latest)
2424
- `main` branch: Provider versions not pinned to keep up with Terraform releases
25-
- `tags` releases: Tags are pinned with versions (use latest
26-
<a href="https://github.com/tomarv2/terraform-aws-target-group/tags" alt="GitHub tag">
27-
<img src="https://img.shields.io/github/v/tag/tomarv2/terraform-aws-target-group" /></a>
28-
in your releases)
25+
- `tags` releases: Tags are pinned with versions (use <a href="https://github.com/tomarv2/terraform-aws-target-group/tags" alt="GitHub tag">
26+
<img src="https://img.shields.io/github/v/tag/tomarv2/terraform-aws-target-group" /></a> in your releases)
2927

3028
**NOTE:**
3129

@@ -56,17 +54,17 @@ export TF_AWS_BUCKET_REGION=us-west-2
5654

5755
- Run and verify the output before deploying:
5856
```
59-
tf -cloud aws plan
57+
tf -cloud aws plan -var='teamid=foo' -var='prjid=bar'
6058
```
6159

6260
- Run below to deploy:
6361
```
64-
tf -cloud aws apply
62+
tf -cloud aws apply -var='teamid=foo' -var='prjid=bar'
6563
```
6664

6765
- Run below to destroy:
6866
```
69-
tf -cloud aws destroy
67+
tf -cloud aws destroy -var='teamid=foo' -var='prjid=bar'
7068
```
7169

7270
> ❗️ **Important** - Two variables are required for using `tf` package:
@@ -87,7 +85,6 @@ tf -cloud aws destroy
8785
module "target_group" {
8886
source = "../"
8987
90-
email = "demo@demo.com"
9188
account_id = "12345679012"
9289
lb_protocol = "HTTP"
9390
lb_port = [80]
@@ -106,35 +103,3 @@ module "target_group" {
106103
```
107104

108105
Please refer to examples directory [link](examples) for references.
109-
110-
## Inputs
111-
112-
| Name | Description | Type | Default | Required |
113-
|------|-------------|------|---------|:--------:|
114-
| account\_id | (Required) AWS account id (used to pull values from shared base module like vpc info, subnet ids) | `any` | n/a | yes |
115-
| alb\_action\_type | n/a | `string` | `"forward"` | no |
116-
| alb\_cert\_arn | alb cert arn | `string` | `""` | no |
117-
| alb\_ssl\_policy | alb ssl policy | `string` | `""` | no |
118-
| aws\_region | The AWS region to create resources | `string` | `"us-west-2"` | no |
119-
| deregistration\_delay | n/a | `string` | `"300"` | no |
120-
| email | email address to be used for tagging (suggestion: use group email address) | `any` | n/a | yes |
121-
| healthcheck\_interval | n/a | `string` | `""` | no |
122-
| healthcheck\_matcher | healthcheck matcher (e.g. 200) | `string` | `""` | no |
123-
| healthcheck\_path | target group healthcheck path | `string` | `""` | no |
124-
| healthcheck\_timeout | n/a | `string` | `""` | no |
125-
| healthy\_threshold | target group healthcheck threshold | `string` | `""` | no |
126-
| lb\_port | n/a | `list` | <pre>[<br> 80<br>]</pre> | no |
127-
| lb\_protocol | n/a | `string` | `"HTTP"` | no |
128-
| prjid | (Required) Name of the project/stack e.g: mystack, nifieks, demoaci. Should not be changed after running 'tf apply' | `any` | n/a | yes |
129-
| profile\_to\_use | Getting values from ~/.aws/credentials | `any` | n/a | yes |
130-
| stickiness | Target group sticky configuration | <pre>object({<br> cookie_duration = number<br> enabled = bool<br> })</pre> | `null` | no |
131-
| target\_type | n/a | `string` | `"instance"` | no |
132-
| teamid | (Required) Name of the team/group e.g. devops, dataengineering. Should not be changed after running 'tf apply' | `any` | n/a | yes |
133-
| unhealthy\_threshold | target group unheathy healthcheck threshold | `string` | `""` | no |
134-
135-
## Outputs
136-
137-
| Name | Description |
138-
|------|-------------|
139-
| target\_group\_arn | n/a |
140-

examples/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module "target_group" {
22
source = "../"
33

4-
email = "demo@demo.com"
54
account_id = "12345679012"
65
lb_protocol = "HTTP"
76
lb_port = [80]

examples/output.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
output "target_groupn_arN" {
1+
output "target_groupn_arn" {
22
description = "The arn of the target group"
33
value = module.target_group.target_group_arn
44
}

examples/sample.tfvars

Lines changed: 0 additions & 10 deletions
This file was deleted.

examples/variables.tf

Lines changed: 0 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -1,91 +1,7 @@
1-
variable "email" {
2-
description = "email address to be used for tagging (suggestion: use group email address)"
3-
}
4-
51
variable "teamid" {
62
description = "(Required) Name of the team/group e.g. devops, dataengineering. Should not be changed after running 'tf apply'"
73
}
84

95
variable "prjid" {
106
description = "(Required) Name of the project/stack e.g: mystack, nifieks, demoaci. Should not be changed after running 'tf apply'"
117
}
12-
13-
variable "profile_to_use" {
14-
description = "Getting values from ~/.aws/credentials"
15-
}
16-
17-
variable "aws_region" {
18-
description = "The AWS region to create resources"
19-
default = "us-west-2"
20-
}
21-
22-
variable "account_id" {
23-
description = "(Required) AWS account id (used to pull values from shared base module like vpc info, subnet ids)"
24-
}
25-
26-
variable "healthcheck_path" {
27-
description = "target group healthcheck path"
28-
default = ""
29-
}
30-
31-
variable "lb_port" {
32-
default = [80]
33-
}
34-
35-
variable "healthy_threshold" {
36-
description = "target group healthcheck threshold"
37-
default = ""
38-
}
39-
40-
variable "unhealthy_threshold" {
41-
description = "target group unheathy healthcheck threshold"
42-
default = ""
43-
}
44-
45-
variable "healthcheck_timeout" {
46-
default = ""
47-
}
48-
49-
variable "healthcheck_interval" {
50-
default = ""
51-
}
52-
53-
variable "healthcheck_matcher" {
54-
description = "healthcheck matcher (e.g. 200)"
55-
default = ""
56-
}
57-
58-
variable "lb_protocol" {
59-
default = "HTTP"
60-
}
61-
62-
variable "alb_cert_arn" {
63-
description = "alb cert arn"
64-
default = ""
65-
}
66-
67-
variable "alb_ssl_policy" {
68-
description = "alb ssl policy"
69-
default = ""
70-
}
71-
72-
variable "alb_action_type" {
73-
default = "forward"
74-
}
75-
76-
variable "stickiness" {
77-
type = object({
78-
cookie_duration = number
79-
enabled = bool
80-
})
81-
description = "Target group sticky configuration"
82-
default = null
83-
}
84-
85-
variable "deregistration_delay" {
86-
default = "300"
87-
}
88-
89-
variable "target_type" {
90-
default = "instance"
91-
}

main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ module "global" {
55
locals {
66
shared_tags = map(
77
"name", "${var.teamid}-${var.prjid}",
8-
"owner", var.email,
98
"team", var.teamid,
109
"project", var.prjid
1110
)

variables.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
variable "email" {
2-
description = "email address to be used for tagging (suggestion: use group email address)"
3-
}
4-
51
variable "teamid" {
62
description = "(Required) Name of the team/group e.g. devops, dataengineering. Should not be changed after running 'tf apply'"
73
}

versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ terraform {
22
required_version = ">= 0.14"
33
required_providers {
44
aws = {
5-
version = "3.29"
5+
version = "~> 3.29"
66
}
77
}
88
}

0 commit comments

Comments
 (0)