adding feature flag

Author: tomarv2

.pre-commit-config.yaml

@@ -3,7 +3,6 @@ repos:
     rev: v1.48.0
     hooks:
       - id: terraform_fmt
-      #- id: terraform_validate
       - id: terraform_tflint
         args:
           - '--args=--only=terraform_deprecated_interpolation'
@@ -28,9 +27,8 @@ repos:
       - id: check-yaml
 
   - repo: https://github.com/bridgecrewio/checkov.git
-    rev: '1.0.864' # change to tag or sha
+    rev: '2.0.469'
     hooks:
     - id: checkov
       verbose: true
-      args:
-      - -d . --framework terraform -o output_format json
+      args: [-d, '.', --framework,'terraform', --skip-check, 'CKV_AWS_158']

README.md

@@ -20,7 +20,7 @@
 ## Versions
 
 - Module tested for Terraform 1.0.1.
-- AWS provider version [3.47.0](https://registry.terraform.io/providers/hashicorp/aws/latest)
+- AWS provider version [3.61.0](https://registry.terraform.io/providers/hashicorp/aws/latest)
 - `main` branch: Provider versions not pinned to keep up with Terraform releases.
 - `tags` releases: Tags are pinned with versions (use <a href="https://github.com/tomarv2/terraform-aws-target-group/tags" alt="GitHub tag">
         <img src="https://img.shields.io/github/v/tag/tomarv2/terraform-aws-target-group" /></a> ).
@@ -42,7 +42,7 @@ terraform destroy -var='teamid=tryme' -var='prjid=project1'
 
 #### Recommended method (store remote state in S3 using prjid and teamid to create directory structure):
 
-- Create python 3.6+ virtual environment
+- Create python 3.8+ virtual environment
 ```
 python3 -m venv <venv name>
 ```
@@ -91,8 +91,6 @@ tf -c=aws destroy -var='teamid=foo' -var='prjid=bar'
 - Read more on [tfremote](https://github.com/tomarv2/tfremote)
 ---
 
-Please refer to examples directory [link](examples) for references.
-
 ##### Target Group
 ```
 module "target_group" {

examples/sample/outputs.tf

@@ -1,4 +1,4 @@
-output "target_groupn_arn" {
-  description = "The arn of the target group"
+output "target_group_arn" {
+  description = "Target group arn"
   value       = module.target_group.target_group_arn
 }

examples/sample/remote_backend.tf

@@ -1,4 +1,4 @@
 output "target_group_arn" {
-  description = "The arn of the target group"
+  description = "Target group arn"
   value       = aws_lb_target_group.target_group.*.arn
 }

outputs.tf

@@ -1,7 +1,8 @@
 # target group
 # https://github.com/cloudposse/terraform-aws-alb-ingress/issues/24
 resource "aws_lb_target_group" "target_group" {
-  count = length(var.lb_port)
+  count = var.deploy_target_group != false ? length(var.lb_port) : 0
+
 
   name     = "${var.teamid}-${var.prjid}-${var.lb_port[count.index]}"
   port     = element(var.lb_port, count.index)

target_group.tf

@@ -105,3 +105,9 @@ variable "target_type" {
   default     = "instance"
   type        = string
 }
+
+variable "deploy_target_group" {
+  description = "feature flag, true or false"
+  default     = true
+  type        = bool
+}

variables.tf

@@ -2,7 +2,7 @@ terraform {
   required_version = ">= 1.0.1"
   required_providers {
     aws = {
-      version = "~> 3.47"
+      version = ">= 3.61"
     }
   }
 }