Skip to content

process: fix tokio process abort issues on windows #4802

@Noah-Kennedy

Description

@Noah-Kennedy

Unfortunately, as a result of rust-lang/rust#95469, we can no longer use tokio::process to communicate with child processes which are themselves rust binaries using std or tokio for stdio. Doing so may result in the child process being aborted.

This was the cause of #4801.

Unfortunately, this doesn't have an easy solution. What we probably need to do is either have the normal stdio stuff use mio, or have the child process stdio use the blocking pool. The latter is very much the better option since we don't want to risk causing issues by setting stdin/stdout to be nonblocking on windows.

Metadata

Metadata

Labels

C-bugCategory: This is a bug.M-processModule: tokio/process

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions