After upgrading to 0.7, the code does not compile #2910

monadbobo · 2024-09-12T18:44:33Z

monadbobo
Sep 12, 2024

Summary

This is my code. I found that after I commented out the bufferlayer and rate_limit layer, the code could compile normally.

    let service_layer = ServiceBuilder::new()
        .layer(HandleErrorLayer::new(handle_error))
        .load_shed()
        .buffer(context.config.max_concurrency_request / 2)
        .timeout(Duration::from_secs(context.config.request_timeout_sec))
        .rate_limit(context.config.rate_request_per_sec, Duration::from_secs(1))
        .concurrency_limit(context.config.max_concurrency_request)
        .into_inner();

    let grpc_layer = ServiceBuilder::new()
        .layer(service_layer)
        .layer(grpc_service_layer)
        .into_inner();


    match tokio::net::TcpListener::bind(context.config.logs_config.rpc_listen).await {
        Ok(rpc_listener) => {
            tokio::spawn(async move {
                Server::builder()
                    .layer(grpc_layer)
                    .add_service(svc)
                    .add_service(trace_svc)
                    .serve_with_incoming_shutdown(
                        TcpListenerStream::new(rpc_listener),
                        async move { rx.changed().await.unwrap() },
                    )
                    .await
                    .unwrap();
            });

compile error:

error[E0277]: the trait bound Buffer<axum::http::Request<AxumBody>, tower::timeout::future::ResponseFuture<tower::limit::concurrency::future::ResponseFuture<FromExtractorResponseFuture<AxumBody, FromExtractor<AccessLogMiddleware<tower_http::trace::Trace<Routes, SharedClassifier<GrpcErrorsAsFailures>, MenciusSpan>>, ExtraAuthHeader, ()>, ExtraRequestIdHeader, ()>>>>: tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>> is not satisfied
--> mencius/src/bin/server.rs:211:22
|
211 | .serve_with_incoming_shutdown(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>> is not implemented for Buffer<Request<Body>, ResponseFuture<ResponseFuture<FromExtractorResponseFuture<Body, ..., ..., ...>>>>, which is required by HandleError<LoadShed<Buffer<axum::http::Request<AxumBody>, tower::timeout::future::ResponseFuture<tower::limit::concurrency::future::ResponseFuture<FromExtractorResponseFuture<AxumBody, FromExtractor<_, ExtraAuthHeader, ()>, ExtraRequestIdHeader, ()>>>>>, fn(Box<(dyn std::error::Error + Send + Sync + 'static)>) -> impl std::future::Future<Output = impl IntoResponse> {handle_error}, ()>: tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>>
|
= help: the trait tower::Service<Req> is implemented for Buffer<Req, F>
= note: required for LoadShed<Buffer<Request<Body>, ResponseFuture<ResponseFuture<...>>>> to implement tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>>
= note: 1 redundant requirement hidden
= note: required for HandleError<LoadShed<Buffer<Request<Body>, ResponseFuture<ResponseFuture<...>>>>, ..., ...> to implement tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>>
= note: the full name for the type has been written to '/Users/simonliu/workspace/mencius/target/debug/deps/mencius_server-b739b15e3d035b59.long-type-8435236371098511931.txt'
= note: consider using --verbose to print the full type name to the console

error[E0277]: the trait bound Routes: tower::Service<axum::http::Request<AxumBody>> is not satisfied
--> mencius/src/bin/server.rs:211:22
|
211 | .serve_with_incoming_shutdown(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait tower::Service<axum::http::Request<AxumBody>> is not implemented for Routes, which is required by Stack<Stack<Stack<TraceLayer<SharedClassifier<GrpcErrorsAsFailures>, MenciusSpan>, Stack<LayerFn<{closure@mencius/src/bin/server.rs:94:25: 94:32}>, Stack<FromExtractorLayer<ExtraAuthHeader, ()>, Stack<FromExtractorLayer<ExtraRequestIdHeader, ()>, tower::layer::util::Identity>>>>, Stack<Stack<ConcurrencyLimitLayer, Stack<RateLimitLayer, Stack<tower::timeout::TimeoutLayer, Stack<BufferLayer<axum::http::Request<AxumBody>>, Stack<LoadShedLayer, Stack<HandleErrorLayer<fn(Box<(dyn std::error::Error + Send + Sync + 'static)>) -> impl std::future::Future<Output = impl IntoResponse> {handle_error}, ()>, tower::layer::util::Identity>>>>>>, tower::layer::util::Identity>>, tower::layer::util::Identity>: Layer<Routes>
|
= help: the trait tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>> is implemented for Routes
= help: for that trait implementation, expected http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>, found AxumBody
= note: required for tower_http::trace::Trace<Routes, SharedClassifier<GrpcErrorsAsFailures>, MenciusSpan> to implement tower::Service<axum::http::Request<AxumBody>>
= note: 4 redundant requirements hidden
= note: required for Timeout<RateLimit<ConcurrencyLimit<FromExtractor<FromExtractor<..., ..., ...>, ..., ...>>>> to implement tower::Service<axum::http::Request<AxumBody>>
= note: required for BufferLayer<axum::http::Request<AxumBody>> to implement Layer<tower::timeout::Timeout<RateLimit<ConcurrencyLimit<FromExtractor<FromExtractor<AccessLogMiddleware<tower_http::trace::Trace<Routes, SharedClassifier<GrpcErrorsAsFailures>, MenciusSpan>>, ExtraAuthHeader, ()>, ExtraRequestIdHeader, ()>>>>>
= note: 4 redundant requirements hidden
= note: required for Stack<Stack<Stack<TraceLayer<SharedClassifier<GrpcErrorsAsFailures>, MenciusSpan>, ...>, ...>, ...> to implement Layer<Routes>
= note: the full name for the type has been written to '/Users/simonliu/workspace/mencius/target/debug/deps/mencius_server-b739b15e3d035b59.long-type-7386371364245122708.txt'
= note: consider using --verbose to print the full type name to the console
= note: the full name for the type has been written to '/Users/simonliu/workspace/mencius/target/debug/deps/mencius_server-b739b15e3d035b59.long-type-17455898285288196973.txt'
= note: consider using --verbose to print the full type name to the console
error[E0277]: the trait bound Buffer<axum::http::Request<AxumBody>, tower::timeout::future::ResponseFuture<tower::limit::concurrency::future::ResponseFuture<FromExtractorResponseFuture<AxumBody, FromExtractor<AccessLogMiddleware<tower_http::trace::Trace<Routes, SharedClassifier<GrpcErrorsAsFailures>, MenciusSpan>>, ExtraAuthHeader, ()>, ExtraRequestIdHeader, ()>>>>: tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>> is not satisfied
--> mencius/src/bin/server.rs:207:17
|
207 | / Server::builder()
208 | | .layer(grpc_layer)
209 | | .add_service(svc)
210 | | .add_service(trace_svc)
... |
213 | | async move { rx.changed().await.unwrap() },
214 | | )
| |_____________________^ the trait tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>> is not implemented for Buffer<Request<Body>, ResponseFuture<ResponseFuture<FromExtractorResponseFuture<Body, ..., ..., ...>>>>, which is required by HandleError<LoadShed<Buffer<axum::http::Request<AxumBody>, tower::timeout::future::ResponseFuture<tower::limit::concurrency::future::ResponseFuture<FromExtractorResponseFuture<AxumBody, FromExtractor<_, ExtraAuthHeader, ()>, ExtraRequestIdHeader, ()>>>>>, fn(Box<(dyn std::error::Error + Send + Sync + 'static)>) -> impl std::future::Future<Output = impl IntoResponse> {handle_error}, ()>: tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>>
|
= help: the trait tower::Service<Req> is implemented for Buffer<Req, F>
= note: required for LoadShed<Buffer<Request<Body>, ResponseFuture<ResponseFuture<...>>>> to implement tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>>
= note: 1 redundant requirement hidden
= note: required for HandleError<LoadShed<Buffer<Request<Body>, ResponseFuture<ResponseFuture<...>>>>, ..., ...> to implement tower::Service<axum::http::Request<http_body_util::combinators::box_body::UnsyncBoxBody<axum::body::Bytes, tonic::Status>>>
= note: the full name for the type has been written to '/Users/simonliu/workspace/mencius/target/debug/deps/mencius_server-b739b15e3d035b59.long-type-8435236371098511931.txt'
= note: consider using --verbose to print the full type name to the console

axum version

0.7.5

monadbobo · 2024-09-13T00:57:39Z

monadbobo
Sep 13, 2024
Author

I know the problem, because the body type returned by the buffer layer is

pub struct Body(BoxBody) ;
type BoxBody = http_body_util::combinators::UnsyncBoxBody<Bytes, Error>;);

while the body type required by add_service is tonic BoxBody

pub type BoxBody = http_body_util::combinators::UnsyncBoxBody<bytes::Bytes, crate::Status>;
    pub fn add_service<S>(&mut self, svc: S) -> Router<L>
    where
        S: Service<Request<BoxBody>, Response = Response<BoxBody>, Error = Infallible>
            + NamedService
            + Clone
            + Send
            + 'static,
        S::Future: Send + 'static,
        L: Clone,
    {
        Router::new(self.clone(), Routes::new(svc))
    }

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

After upgrading to 0.7, the code does not compile #2910

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

After upgrading to 0.7, the code does not compile #2910

Uh oh!

monadbobo Sep 12, 2024

Summary

axum version

Replies: 1 comment

Uh oh!

monadbobo Sep 13, 2024 Author

monadbobo
Sep 12, 2024

monadbobo
Sep 13, 2024
Author