Unable to pass tokio-postgres pool connections to handler

[bontxa]

I'm a Rust newbie. I'm trying to create a pool of tokio-postgres connections to a handler, it should use the connection for fill a database table. I used deadpool-postgres and it seems it creates the pool. Problem is that i can't pass the pool to the handler.

here is the code related to the problem:

use axum::{
    extract::State,
    routing::{get, post},
    Router,
    http::{Response, StatusCode},
    extract::Form,
    response::{IntoResponse, Redirect}
    };
use std::{convert::Infallible, fs, net::SocketAddr};
use tower_http::cors::{Any, CorsLayer};
use tokio_postgres::NoTls;
use deadpool_postgres::{Config, ManagerConfig, Pool, RecyclingMethod};

#[derive(Clone)]
struct AppState {
    db_pool: Pool
}

impl  AppState {
    async fn make_pool() -> Self {
        let mut config = Config::new();
        
        config.user = Some("postgres".to_string());
        config.password = Some("postgres".to_string());
        config.dbname = Some("localhost".to_string());
        config.host = Some("localhost".to_string());
        config.port = Some(5432);
        config.manager = Some(ManagerConfig { recycling_method: RecyclingMethod::Fast });
        
        let pool = config.create_pool(None, NoTls).unwrap();
        pool.resize(15);
        AppState {
            db_pool: pool,
        }
    }
}
 

async fn handle_form(Form(data): Form<FormData>, State(client): State<AppState>) -> Result<Redirect, deadpool_postgres::PoolError> {
    println!("->>\thandle_form__handler called");

    let conn = client.db_pool.get().await.unwrap();

    let values = (&data.nome, &data.cognome, &data.email);

    let query = "INSERT INTO users (nome, cognome, email) VALUES ($1, $2, $3)";
    if let Err(e) = conn.execute(query, &[&values.0, &values.1, &values.2]).await.map_err(|e| Into::<deadpool_postgres::PoolError>::into(e)) {
        eprintln!("error executing query: {}", e);
        return Err(e.into());
    }
    Ok(Redirect::to("/form/success/"))
}


#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {

    let client = AppState::make_pool().await;

    let cors = CorsLayer::new().allow_origin(Any);

    let app = Router::new()
        .route("/", get(index_handler))
        .route("/about/", get(about_handler))
        .route("/form/", get(form_handler))
        .route("/form/submit-form/", post(handle_form))
        .route("/form/success/", get(success_handler))
        .with_state(client)
        .layer(cors);
    
    let addr = SocketAddr::from(([127, 0, 0, 1], 8000));
    println!("listening on {}", addr);
        
    axum::Server::bind(&addr)
        .serve(app.into_make_service())
        .await
        .unwrap();

    Ok(())
}

error reported is:

error[E0277]: the trait bound `fn(Form<FormData>, State<AppState>) -> impl Future<Output = Result<Redirect, deadpool::managed::errors::PoolError<tokio_postgres::Error>>> {handle_form}: Handler<_, _, _>` is not satisfied
   --> src/main.rs:127:43
    |
127 |         .route("/form/submit-form/", post(handle_form))
    |                                      ---- ^^^^^^^^^^^ the trait `Handler<_, _, _>` is not implemented for fn item `fn(Form<FormData>, State<AppState>) -> impl Future<Output = Result<Redirect, deadpool::managed::errors::PoolError<tokio_postgres::Error>>> {handle_form}`
    |                                      |
    |                                      required by a bound introduced by this call
    |
    = help: the following other types implement trait `Handler<T, S, B>`:
              <Layered<L, H, T, S, B, B2> as Handler<T, S, B2>>
              <MethodRouter<S, B> as Handler<(), S, B>>
note: required by a bound in `post`
   --> /home/bontxa/.cargo/registry/src/github.com-1ecc6299db9ec823/axum-0.6.18/src/routing/method_routing.rs:407:1
    |
407 | top_level_handler_fn!(post, POST);
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `post`
    = note: this error originates in the macro `top_level_handler_fn` (in Nightly builds, run with -Z macro-backtrace for more info)

to fix this error i change this line:

async fn handle_form(Form(data): Form<FormData>, State(client): State<AppState>) -> Result<Redirect, deadpool_postgres::PoolError>

in:

async fn handle_form(Form(data): Form<FormData>, State(client): State<AppState<Pool>>) -> Result<Redirect, deadpool_postgres::PoolError>

but now the new error is:

error[E0107]: struct takes 0 generic arguments but 1 generic argument was supplied
   --> src/main.rs:100:71
    |
100 | async fn handle_form(Form(data): Form<FormData>, State(client): State<AppState<Pool>>) -> Result<Redirect, deadpool_postgres::PoolError> {
    |                                                                       ^^^^^^^^------ help: remove these generics
    |                                                                       |
    |                                                                       expected 0 generic arguments
    |
note: struct defined here, with 0 generic parameters
   --> src/main.rs:76:8
    |
76  | struct AppState {
    |        ^^^^^^^^

this is my Cargo.toml dependencies section:

[dependencies]
axum = "0.6.18"
tokio = { version = "1.28", features = ["full"] }
tokio-postgres = { version = "0.7.8", features = ["with-uuid-0_8"] }
tower-http = { version = "0.4.0", features = ["cors"] }
serde = { version = "1.0.162", features = ["derive"] }
deadpool-postgres = "0.10.5"

I halso tried with 'Extension' instead of 'State' but the situation is the same. Any help is appreciated, thanks in advance.

[ceffiro]

Any updates on this?

@bontxa
Did you figure out a way to solve the problem?

[davidpdrsn]

I think it’s caused by

Since parsing form data might require consuming the request body, the Form extractor must be last if there are multiple extractors in a handler. See “the order of extractors”

From https://docs.rs/axum/0.7.2/axum/struct.Form.html