Drop one unnecessary allocation added in aa2f6b4

TheBlueMatt · TheBlueMatt · commit 0abf068ad1a8 · 2024-10-03T17:23:32.000Z
In aa2f6b4 we refactored `lightning-invoice` de/serialization to use the new version of `bech32`, but ended up adding one unnecessary allocation in our offers logic, which we drop here.
diff --git a/lightning/src/offers/parse.rs b/lightning/src/offers/parse.rs
@@ -58,7 +58,7 @@ mod sealed {
 
 			let parsed = CheckedHrpstring::new::<NoChecksum>(encoded.as_ref())?;
 			let hrp = parsed.hrp();
-			if hrp.to_string() != Self::BECH32_HRP {
+			if hrp.as_str() != Self::BECH32_HRP {
 				return Err(Bolt12ParseError::InvalidBech32Hrp);
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ mod sealed {`
`58`	`58`
`59`	`59`	`let parsed = CheckedHrpstring::new::<NoChecksum>(encoded.as_ref())?;`
`60`	`60`	`let hrp = parsed.hrp();`
`61`		`- if hrp.to_string() != Self::BECH32_HRP {`
	`61`	`+ if hrp.as_str() != Self::BECH32_HRP {`
`62`	`62`	`return Err(Bolt12ParseError::InvalidBech32Hrp);`
`63`	`63`	`}`
`64`	`64`