Skip to content

Commit 05b14b0

Browse files
committed
Updating the theme descriptors
- Changed name to commandName - Changed description to mainDescription
1 parent df8e634 commit 05b14b0

File tree

6 files changed

+27
-27
lines changed

6 files changed

+27
-27
lines changed

config.json

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,39 +3,39 @@
33
"url": "http://tldr-pages.github.io/assets/tldr.zip",
44
"themes": {
55
"simple": {
6-
"name": "bold,underline",
7-
"description": "bold",
6+
"commandName": "bold, underline",
7+
"mainDescription": "bold",
88
"exampleDescription": "",
99
"exampleCode": "",
1010
"exampleToken": "underline"
1111
},
1212
"base16": {
13-
"name": "bold",
14-
"description": "",
13+
"commandName": "bold",
14+
"mainDescription": "",
1515
"exampleDescription": "green",
1616
"exampleCode": "red",
1717
"exampleToken": "cyan"
1818
},
1919
"ocean": {
20-
"name": "bold,cyan",
21-
"description": "",
20+
"commandName": "bold, cyan",
21+
"mainDescription": "",
2222
"exampleDescription": "green",
2323
"exampleCode": "cyan",
2424
"exampleToken": "dim"
2525
},
2626
"inverse": {
27-
"name": "bold,inverse",
28-
"description": "inverse",
27+
"commandName": "bold, inverse",
28+
"mainDescription": "inverse",
2929
"exampleDescription": "black",
3030
"exampleCode": "inverse",
31-
"exampleToken": "green,bgBlack,inverse"
31+
"exampleToken": "green, bgBlack, inverse"
3232
},
3333
"matrix": {
34-
"name": "bold",
35-
"description": "underline",
36-
"exampleDescription": "green,bgBlack",
37-
"exampleCode": "green,bgBlack",
38-
"exampleToken": "green,bold,bgBlack"
34+
"commandName": "bold",
35+
"mainDescription": "underline",
36+
"exampleDescription": "green, bgBlack",
37+
"exampleCode": "green, bgBlack",
38+
"exampleToken": "green, bold, bgBlack"
3939
}
4040
},
4141
"theme": "simple"

lib/config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,10 @@ function validateThemeItem(field, key) {
8383
];
8484
for (var item in field) {
8585
if (field.hasOwnProperty(item)) {
86-
var tokens = field[item].split(',');
86+
var tokens = field[item].replace(/\s+/g,'').split(',');
8787
for (var i=0; i < tokens.length; i++) {
8888
if (validValues.indexOf(tokens[i]) < 0) {
89-
return 'Invalid ANSI color : ' + tokens[i] + ' in ' + key + ' theme';
89+
return 'Invalid theme value : ' + tokens[i] + ' in ' + key + ' theme';
9090
}
9191
}
9292
}

lib/render.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ exports.toANSI = function(page) {
1919

2020
var output = [];
2121

22-
output.push(' ' + theme.renderName(page.name));
22+
output.push(' ' + theme.renderCommandName(page.name));
2323
output.push('');
24-
output.push(' ' + theme.renderDescription(page.description.replace(/\n/g, '\n ')));
24+
output.push(' ' + theme.renderMainDescription(page.description.replace(/\n/g, '\n ')));
2525
output.push('');
2626

2727
page.examples.forEach(function(example) {

lib/theme.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ var Theme = function(options) {
3030
};
3131

3232
return {
33-
renderName: renderPartMemoized('name'),
34-
renderDescription: renderPartMemoized('description'),
33+
renderCommandName: renderPartMemoized('commandName'),
34+
renderMainDescription: renderPartMemoized('mainDescription'),
3535
renderExampleDescription: renderPartMemoized('exampleDescription'),
3636
renderExampleCode: renderPartMemoized('exampleCode'),
3737
renderExampleToken: renderPartMemoized('exampleToken')

test/config.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ describe('Config', function() {
1818
'{' +
1919
'"themes": {' +
2020
' "simple": {' +
21-
' "name": "bold,underline",' +
22-
' "description": "#876992",' +
21+
' "commandName": "bold,underline",' +
22+
' "mainDescription": "#876992",' +
2323
' "exampleDescription": "",' +
2424
' "exampleCode": "",' +
2525
' "exampleToken": "underline"' +
@@ -52,7 +52,7 @@ describe('Config', function() {
5252
it('should validate the custom config format', function() {
5353
fs.readFileSync.onCall(0).returns(DEFAULT);
5454
fs.readFileSync.onCall(1).returns(CUSTOM_INVALID);
55-
config.get.should.throw(/Invalid ANSI color/);
55+
config.get.should.throw(/Invalid theme value/);
5656
});
5757

5858
});

test/theme.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,21 @@ describe('Theme', function() {
66
describe('Rendering', function() {
77

88
var theme = new Theme({
9-
name: 'green, bold',
10-
description: 'red, underline',
9+
commandName: 'green, bold',
10+
mainDescription: 'red, underline',
1111
exampleDescription: 'blue',
1212
exampleCode: 'bold',
1313
exampleToken: 'yellow,dim,underline'
1414
});
1515

1616
it('should render name with green and bold', function () {
17-
theme.renderName('text')
17+
theme.renderCommandName('text')
1818
.should.equal(
1919
chalk.green.bold('text'));
2020
});
2121

2222
it('should render description with red and underline', function () {
23-
theme.renderDescription('text')
23+
theme.renderMainDescription('text')
2424
.should.equal(
2525
chalk.red.underline('text'));
2626
});

0 commit comments

Comments
 (0)