Skip to content

Fix document(HtmlTag) in TagCreator #188

@obecker

Description

@obecker

There is this method in TagCreator:

    public static String document(HtmlTag htmlTag) {
        return document().render() + htmlTag.render();
    }

This returns a String by calling render(), thus it prevents using the new render possibilities introduced with #179

A better approach would be if there is a Document class that implements Renderable and that handles the correct rendering.

Apparently this would break code written for j2html 1.*, so it is something we should consider for a 2.* release.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions