Skip to content

Commit e27b2c4

Browse files
dkegel-fastlydeadprogram
authored andcommitted
circleci: our version of misspell is no longer supported with go < 1.21, so disable lint in go 1.19 ci job
I jumped through quite a few hoops to get test-llvm15-go119 to work, but this last hoop seems not worth jumping through: cd internal/tools && go generate -tags tools ./ /go/pkg/mod/github.com/golangci/misspell@v0.6.0/mime.go:10:2: package slices is not in GOROOT (/usr/local/go/src/slices) tools.go:12: running "go": exit status 1 make: *** [GNUmakefile:952: tools] Error 1 I mean, we could patch misspell to not use slices, or to use the prerelease slices, but...
1 parent 8135be4 commit e27b2c4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.circleci/config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ jobs:
104104
steps:
105105
- test-linux:
106106
llvm: "15"
107+
# "make lint" fails before go 1.21 because internal/tools/go.mod specifies packages that require go 1.21
108+
fmt-check: false
107109
resource_class: large
108110
test-llvm18-go122:
109111
docker:

0 commit comments

Comments
 (0)