compiler: fix basic block context

aykevl · deadprogram · commit 2fb5174910fd · 2022-06-16T07:59:21.000+02:00
llvm.AddBasicBlock should never be used. Instead, we should use the
AddBasicBlock method of the current LLVM context.

This didn't lead to any bugs... yet. But probably would, eventually.
diff --git a/compiler/alias.go b/compiler/alias.go
@@ -86,7 +86,7 @@ func (b *builder) createAlias(alias llvm.Value) {
 		pos := b.program.Fset.Position(b.fn.Pos())
 		b.SetCurrentDebugLocation(uint(pos.Line), uint(pos.Column), b.difunc, llvm.Metadata{})
 	}
-	entryBlock := llvm.AddBasicBlock(b.llvmFn, "entry")
+	entryBlock := b.ctx.AddBasicBlock(b.llvmFn, "entry")
 	b.SetInsertPointAtEnd(entryBlock)
 	if b.llvmFn.Type() != alias.Type() {
 		b.addError(b.fn.Pos(), "alias function should have the same type as aliasee "+alias.Name())

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func (b *builder) createAlias(alias llvm.Value) {`
`86`	`86`	`pos := b.program.Fset.Position(b.fn.Pos())`
`87`	`87`	`b.SetCurrentDebugLocation(uint(pos.Line), uint(pos.Column), b.difunc, llvm.Metadata{})`
`88`	`88`	`}`
`89`		`- entryBlock := llvm.AddBasicBlock(b.llvmFn, "entry")`
	`89`	`+ entryBlock := b.ctx.AddBasicBlock(b.llvmFn, "entry")`
`90`	`90`	`b.SetInsertPointAtEnd(entryBlock)`
`91`	`91`	`if b.llvmFn.Type() != alias.Type() {`
`92`	`92`	`b.addError(b.fn.Pos(), "alias function should have the same type as aliasee "+alias.Name())`