ColorScheme autocmd not triggered when using custom colors.

[sweiglbosker]

to repro:

vim.api.nvim_create_autocmd("ColorScheme", { callback = function(args)
  vim.api.nvim_set_hl(0, 'Normal', { bg = "#ff0000" })
end})

require('tinted-colorscheme').setup({
  base00 = "#0f1419", base01 = "#131721", base02 = "#272d38", base03 = "#3e4b59",
  base04 = "#bfbdb6", base05 = "#e6e1cf", base06 = "#e6e1cf", base07 = "#f3f4f5",
  base08 = "#f07178", base09 = "#ff8f40", base0A = "#ffb454", base0B = "#b8cc52",
  base0C = "#95e6cb", base0D = "#59c2ff", base0E = "#d2a6ff", base0F = "#e6b673",
})

This can be fixed with a vim.cmd[[doautocmd ColorScheme]] where necessary.

[JamyGolden]

We do have it triggering ColorScheme autocmd when the theme is switched using Tinty. Why would you need the autocmd to trigger when require('tinted-colorscheme').setup( is run since you could run the code in the callback right after the setup is run. For example:

require('tinted-colorscheme').setup({
  base00 = "#0f1419", base01 = "#131721", base02 = "#272d38", base03 = "#3e4b59",
  base04 = "#bfbdb6", base05 = "#e6e1cf", base06 = "#e6e1cf", base07 = "#f3f4f5",
  base08 = "#f07178", base09 = "#ff8f40", base0A = "#ffb454", base0B = "#b8cc52",
  base0C = "#95e6cb", base0D = "#59c2ff", base0E = "#d2a6ff", base0F = "#e6b673",
})
vim.api.nvim_set_hl(0, 'Normal', { bg = "#ff0000" })

[sweiglbosker]

We do have it triggering ColorScheme autocmd when the theme is switched using Tinty. Why would you need the autocmd to trigger when require('tinted-colorscheme').setup( is run since you could run the code in the callback right after the setup is run. For example:

require('tinted-colorscheme').setup({
base00 = "#0f1419", base01 = "#131721", base02 = "#272d38", base03 = "#3e4b59",
base04 = "#bfbdb6", base05 = "#e6e1cf", base06 = "#e6e1cf", base07 = "#f3f4f5",
base08 = "#f07178", base09 = "#ff8f40", base0A = "#ffb454", base0B = "#b8cc52",
base0C = "#95e6cb", base0D = "#59c2ff", base0E = "#d2a6ff", base0F = "#e6b673",
})
vim.api.nvim_set_hl(0, 'Normal', { bg = "#ff0000" })

The example i included was just the simplest way to demonstrate this behavior.

I use setup like this to apply custom themes, and it is integrated with my own theme manager (not tinty). I use ColorScheme autocmd as a way of hooking scheme updates, so i can apply certain colorscheme changes automatically on scheme change, usually by fetching the palette from the new colorscheme. If this isn’t a misuse of the api, it might make sense to move this logic to wherever a new scheme gets applied, whether it be in setup or by tinty.