fix(root/enhanced-processing): ignore non-media streams when scanning for audio sessions

timschneeb · timschneeb · commit c31cddf28de2 · 2023-09-09T21:27:24.000+02:00
diff --git a/app/src/main/java/me/timschneeberger/rootlessjamesdsp/session/root/RootSessionDatabase.kt b/app/src/main/java/me/timschneeberger/rootlessjamesdsp/session/root/RootSessionDatabase.kt
@@ -60,7 +60,13 @@ class RootSessionDatabase(context: Context) : BaseSessionDatabase(context) {
         }
     }
 
-    override fun shouldAcceptSessionDump(id: Int, session: AudioSessionDumpEntry) = true
+    override fun shouldAcceptSessionDump(id: Int, session: AudioSessionDumpEntry): Boolean {
+        if (!session.isUsageRecordable()) {
+            Timber.d("Skipped session $id due to usage ($session)")
+            return false
+        }
+        return true
+    }
     override fun shouldAddSession(id: Int, uid: Int, packageName: String) = true
 
     override fun onSessionRemoved(item: IEffectSession) {

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,13 @@ class RootSessionDatabase(context: Context) : BaseSessionDatabase(context) {`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`
`63`		`- override fun shouldAcceptSessionDump(id: Int, session: AudioSessionDumpEntry) = true`
	`63`	`+ override fun shouldAcceptSessionDump(id: Int, session: AudioSessionDumpEntry): Boolean {`
	`64`	`+ if (!session.isUsageRecordable()) {`
	`65`	`+ Timber.d("Skipped session $id due to usage ($session)")`
	`66`	`+ return false`
	`67`	`+ }`
	`68`	`+ return true`
	`69`	`+ }`
`64`	`70`	`override fun shouldAddSession(id: Int, uid: Int, packageName: String) = true`
`65`	`71`
`66`	`72`	`override fun onSessionRemoved(item: IEffectSession) {`