Controller not receiving any commands

[vernonal]

This was all working last year but now (after library updates) my controllers are not receiving any commands.
Worked on this for a bit but don't seem to be getting anywhere.
I have reverted back to the default controller package to remove the possibility that my application is the cause of anything.

These are the commands I am sending from NodeRed the controller id is 12.
"[ {"id":12,"type":202,"data":1748478911790}, {"id":12,"type":200,"data":423101550}, {"id":12,"type":201,"data":16024100}]"

The gateway setup is like this

#define UNIT_MAC           0x01  // The address of this gateway
#define ESPNOW_NEIGHBOR_1  0x00  // Address of ESP-NOW neighbor #1
#define ESPNOW_NEIGHBOR_2  0x00  // Address of ESP-NOW neighbor #2
#define LORA_NEIGHBOR_1    0x02  // Address of LoRa neighbor #1
#define LORA_NEIGHBOR_2    0x04  // Address of LoRa neighbor #2

// Interfaces
#define USE_ESPNOW  
#define USE_LORA
//#define USE_WIFI  // Will cause errors if used with ESP-NOW. Use a serial link instead!
//#define USE_ETHERNET

// Routing
// Options: sendESPNowNbr(1 or 2); sendESPNowPeers(); sendLoRaNbr(1 or 2); broadcastLoRa(); sendSerial(); sendMQTT();
#define ESPNOWG_ACT    sendSerial();
#define LORAG_ACT      sendSerial();
#define SERIAL_ACT     sendESPNowPeers(); sendLoRaNbr(1); sendLoRaNbr(2); broadcastLoRa(); //
#define MQTT_ACT          
#define INTERNAL_ACT   sendSerial();
#define ESPNOW1_ACT    
#define ESPNOW2_ACT                   
#define LORA1_ACT      sendSerial();
#define LORA2_ACT      sendSerial();

I can see the gateway receive the commands and it says it is moving it along

20:15:11.279 ->     Incoming Serial
20:15:11.315 -> [1] DR data: [{"id":12,"type":202,"data":1.748477673e12},{"id":12,"type":200,"data":4.231015e8},{"id":12,"type":201,"data":1.60241e7}]
20:15:11.315 ->     Sending DR to ESP-NOW peers.
20:15:11.347 ->     Sending to LoRa neighbor buffer
20:15:11.382 ->     Sending to LoRa broadcast buffer
20:15:11.421 ->     Sending LoRa DR...

The controller seems to be registered correctly with the gateway

20:06:39.727 ->     Initializing FDRS Node!
20:06:39.727 ->     Reading ID 12
20:06:39.727 ->     Gateway: 1
20:06:39.727 ->     Debugging verbosity level: 1
20:06:39.727 -> [1] ESP-NOW is enabled.
20:06:39.727 ->     Initializing ESP-NOW!
20:06:39.757 ->      ESP-NOW LR mode is active!
20:06:39.757 ->      ESP-NOW Initialized.
20:06:39.757 -> [1] ESP-NOW ping sent to 0x1
20:06:39.791 -> [1] ESP-NOW Ping Reply in 44ms from 0x1
20:06:39.791 ->     ESP-NOW peer registration request submitted to 0x1
20:06:39.791 ->     Registration accepted. Timeout: 300000
20:06:39.791 ->     Subscribing to DataReading ID 12
20:11:39.771 -> [1] Refreshing registration to 0x1

But it is not receiving the commands send from nodeRed
If someone could point me in the right direction in would appreciate it.
thanks in advance

[vernonal]

Some more info, I changed the debug level to developer and an now receiving this message when I send the command.
09:04:08.215 -> [2] Incoming ESP-NOW Data from 0x1 of unexpected size 21

I tried sending a single message and was successful, so there seems to be a problem chaining the messages together like I was doing before ?

[timmbogner]

Hey @vernonal thanks for this report. At a quick glance, that's looking like maybe something changed or was fixed within the ESP-NOW protocol. It could possibly be something with timing as well. I will have an opportunity to get a test running either tomorrow or Monday and report back my results.

The one thing I'd ask you to try in terms of testing: Roll back your ESP board definitions to an earlier version and re-flash things to see if that affects them.
Assuming you're using ESP32s: I haven't actually tested things since around when ESP32 board definitions version 3.0 was released.

EDIT: Thanks Jeff, and good call adding that little bit of error reporting!

[aviateur17]

I see the issue.

src/fdrs_node_espnow.h line 111:
else if((len == sizeof(DataReading)))
Should be
else if(len % sizeof(DataReading) = 0)
That way any multiple of Datareading is accepted. Based on error, Len should be a multiple of 7. 3 DRs = 3*7 = 21 bytes. 21 mod 7 = 0 and thus should work as intended.

@vernonal, are you able to try to manually change that line and then compile and download?

[vernonal]

Good Morning,
I changed the line (modifying the suggested '= 0' to '== 0' at the end) and every now seems to be working fine.
Indications are that I am now getting less missing messages than I was last year so this is an improvement.
Thanks for all of your help.

[aviateur17]

Yeah, == 0. Too many programming languages to remember. I'll make a PR for this so others do not have the same issue. Glad it's working now for you.

[timmbogner]

Whoops, I guess I should really refrain from speculating. Thanks again for reporting this!