Merge pull request #82 from derechtenap/0.2.1/bugfix-impossible-score-state

Add helper function to detect busts for different checkout types

Author: timderes

renderer/lib/playing/stats/isBust.ts

@@ -0,0 +1,26 @@
+import type { Checkout } from "types/match";
+
+/**
+ * Checks if the current throw results in a bust situation based on the remaining score.
+ * A bust occurs when a player attempts to throw a score that would exceed the remaining score or violates
+ * specific throw rules (e.g., attempting a double with a score less than 2).
+ *
+ * @param {Checkout} checkout - The type of checkout being attempted. Can be "Any", "Single", "Double" or "Triple".
+ * @param {number} remainingScore - The remaining score to be reduced. Should be a positive number.
+ * @returns {boolean} - Returns `true` if it's a bust, `false` otherwise.
+ *
+ * @example
+ * isBust("Double", 1); // returns true (because a Double requires at least 2 points)
+ * isBust("Triple", 2); // returns true (because a Triple requires at least 3 points)
+ * isBust("Double", 4); // returns false (valid Double checkout with remaining score of 4)
+ */
+const isBust = (checkout: Checkout, remainingScore: number): boolean => {
+  if (remainingScore < 0) return true;
+
+  if (checkout === "Double" && remainingScore < 2) return true;
+  if (checkout === "Triple" && remainingScore < 3) return true;
+
+  return false;
+};
+
+export default isBust;

renderer/pages/[locale]/match/playing.tsx

@@ -61,6 +61,7 @@ import { useElapsedTime } from "use-elapsed-time";
 import { modals } from "@mantine/modals";
 import addMatchToDatabase from "@/lib/db/matches/addMatch";
 import getFirstNineAverage from "@/lib/playing/stats/getFirstNineAverage";
+import isBust from "@/lib/playing/stats/isBust";
 
 const PlayingPage: NextPage = () => {
   const theme = useMantineTheme();
@@ -229,7 +230,7 @@ const PlayingPage: NextPage = () => {
 
     const updatedMatchRound: MatchRound = {
       elapsedTime: elapsedTime,
-      isBust: newScoreLeft < 0 ? true : false,
+      isBust: isBust(checkout, newScoreLeft),
       roundAverage:
         matchRound.length > 0 ? totalRoundScore / matchRound.length : 0,
       roundTotal: totalRoundScore,
@@ -239,7 +240,6 @@ const PlayingPage: NextPage = () => {
           ? matchRound
           : filledThrowDetails.slice(0, THROWS_PER_ROUND),
     };
-
     const updatedCurrentPlayer: Player = {
       ...currentPlayer,
       rounds: [...currentPlayer.rounds, updatedMatchRound],
@@ -248,7 +248,8 @@ const PlayingPage: NextPage = () => {
       scoreLeft:
         isWinner && newScoreLeft === 0
           ? 0
-          : newScoreLeft > 0
+          : // Update score only if >0 and is not a bust!
+          newScoreLeft > 0 && !isBust(checkout, newScoreLeft)
           ? newScoreLeft
           : currentPlayer.scoreLeft,
     };