Skip to content

Commit 8729350

Browse files
authored
Merge pull request #42 from nrc/prost
Migrate to Prost
2 parents e44c87f + 199c6a2 commit 8729350

File tree

4 files changed

+11
-17
lines changed

4 files changed

+11
-17
lines changed

Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,13 @@ fxhash = "0.2"
2424
grpcio = { version = "0.5.0-alpha", features = [ "secure", "prost-codec" ], default-features = false }
2525
lazy_static = "0.2.1"
2626
log = "0.3.9"
27-
protobuf = "2"
2827
serde = "1.0"
2928
serde_derive = "1.0"
3029
tokio-core = "0.1"
3130
tokio-timer = "0.2"
3231

3332
[dependencies.kvproto]
3433
git = "https://github.com/pingcap/kvproto.git"
35-
branch = "raft-0.5.0"
3634

3735
[dependencies.prometheus]
3836
version = "0.4.2"

src/rpc/client.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ use futures::{
1818
use grpcio::{EnvBuilder, Environment};
1919
use kvproto::kvrpcpb;
2020
use log::*;
21-
use protobuf::Message;
2221

2322
use crate::{
2423
raw::ColumnFamily,
@@ -478,7 +477,7 @@ impl RegionContext {
478477

479478
impl From<RegionContext> for kvrpcpb::Context {
480479
fn from(mut ctx: RegionContext) -> kvrpcpb::Context {
481-
let mut kvctx = kvrpcpb::Context::new();
480+
let mut kvctx = kvrpcpb::Context::default();
482481
kvctx.set_region_id(ctx.region.id);
483482
kvctx.set_region_epoch(ctx.region.take_region_epoch());
484483
kvctx.set_peer(ctx.region.peer().expect("leader must exist").into_inner());

src/rpc/pd/leader.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ use fxhash::FxHashSet as HashSet;
1717
use grpcio::{CallOption, Environment, WriteFlags};
1818
use kvproto::pdpb;
1919
use log::*;
20-
use protobuf::Message;
2120
use tokio_core::reactor::{Core, Handle as OtherHandle};
2221

2322
use crate::{
@@ -34,9 +33,8 @@ use crate::{
3433

3534
macro_rules! pd_request {
3635
($cluster_id:expr, $type:ty) => {{
37-
use ::protobuf::Message;
38-
let mut request = <$type>::new();
39-
let mut header = ::kvproto::pdpb::RequestHeader::new();
36+
let mut request = <$type>::default();
37+
let mut header = ::kvproto::pdpb::RequestHeader::default();
4038
header.set_cluster_id($cluster_id);
4139
request.set_header(header);
4240
request
@@ -354,7 +352,7 @@ fn connect(
354352
let client = security_mgr.connect(env, addr, pdpb::PdClient::new)?;
355353
let option = CallOption::default().timeout(timeout);
356354
let resp = client
357-
.get_members_opt(&pdpb::GetMembersRequest::new(), option)
355+
.get_members_opt(&pdpb::GetMembersRequest::default(), option)
358356
.map_err(Error::from)?;
359357
Ok((client, resp))
360358
}

src/rpc/tikv/client.rs

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use std::{fmt, sync::Arc, time::Duration};
88
use futures::Future;
99
use grpcio::{CallOption, Environment};
1010
use kvproto::{errorpb, kvrpcpb, tikvpb::TikvClient};
11-
use protobuf::{self, Message};
1211

1312
use crate::{
1413
rpc::{
@@ -160,7 +159,7 @@ has_no_error!(kvrpcpb::RawBatchScanResponse);
160159

161160
macro_rules! raw_request {
162161
($context:expr, $type:ty) => {{
163-
let mut req = <$type>::new();
162+
let mut req = <$type>::default();
164163
let (region, cf) = $context.into_inner();
165164
req.set_context(region.into());
166165
if let Some(cf) = cf {
@@ -172,15 +171,15 @@ macro_rules! raw_request {
172171

173172
macro_rules! txn_request {
174173
($context:expr, $type:ty) => {{
175-
let mut req = <$type>::new();
174+
let mut req = <$type>::default();
176175
req.set_context($context.into_inner().into());
177176
req
178177
}};
179178
}
180179

181180
impl From<Mutation> for kvrpcpb::Mutation {
182181
fn from(mutation: Mutation) -> kvrpcpb::Mutation {
183-
let mut pb = kvrpcpb::Mutation::new();
182+
let mut pb = kvrpcpb::Mutation::default();
184183
match mutation {
185184
Mutation::Put(k, v) => {
186185
pb.set_op(kvrpcpb::Op::Put);
@@ -206,7 +205,7 @@ impl From<Mutation> for kvrpcpb::Mutation {
206205

207206
impl From<TxnInfo> for kvrpcpb::TxnInfo {
208207
fn from(txn_info: TxnInfo) -> kvrpcpb::TxnInfo {
209-
let mut pb = kvrpcpb::TxnInfo::new();
208+
let mut pb = kvrpcpb::TxnInfo::default();
210209
pb.set_txn(txn_info.txn);
211210
pb.set_status(txn_info.status);
212211
pb
@@ -317,7 +316,7 @@ impl KvClient {
317316
mutations: impl Iterator<Item = Mutation>,
318317
commit_version: u64,
319318
) -> impl Future<Item = kvrpcpb::ImportResponse, Error = Error> {
320-
let mut req = kvrpcpb::ImportRequest::new();
319+
let mut req = kvrpcpb::ImportRequest::default();
321320
req.set_mutations(mutations.map(Into::into).collect());
322321
req.set_commit_version(commit_version);
323322

@@ -624,7 +623,7 @@ impl KvClient {
624623

625624
#[inline]
626625
fn convert_to_grpc_pair(pair: KvPair) -> kvrpcpb::KvPair {
627-
let mut result = kvrpcpb::KvPair::new();
626+
let mut result = kvrpcpb::KvPair::default();
628627
let (key, value) = pair.into_inner();
629628
result.set_key(key.into_inner());
630629
result.set_value(value.into_inner());
@@ -652,7 +651,7 @@ impl KvClient {
652651
#[inline]
653652
fn convert_to_grpc_range(range: (Option<Key>, Option<Key>)) -> kvrpcpb::KeyRange {
654653
let (start, end) = range;
655-
let mut range = kvrpcpb::KeyRange::new();
654+
let mut range = kvrpcpb::KeyRange::default();
656655
start.map(|k| range.set_start_key(k.into_inner())).unwrap();
657656
end.map(|k| range.set_end_key(k.into_inner())).unwrap();
658657
range

0 commit comments

Comments
 (0)