Skip to content

Commit 13aafc6

Browse files
committed
fix: prometheus feature flag fixup
Signed-off-by: John Lewis <github@jlewis.sh>
1 parent 2d75f2d commit 13aafc6

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ mod pd;
107107
mod proto;
108108
mod region;
109109
mod region_cache;
110+
#[cfg(feature = "prometheus")]
110111
mod stats;
111112
mod store;
112113
mod timestamp;

src/pd/retry.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ use crate::proto::pdpb::{self};
2020
use crate::region::RegionId;
2121
use crate::region::RegionWithLeader;
2222
use crate::region::StoreId;
23+
#[cfg(feature = "prometheus")]
2324
use crate::stats::pd_stats;
2425
use crate::Error;
2526
use crate::Result;
@@ -75,15 +76,22 @@ impl<Cl> RetryClient<Cl> {
7576

7677
macro_rules! retry_core {
7778
($self: ident, $tag: literal, $call: expr) => {{
79+
#[cfg(feature = "prometheus")]
7880
let stats = pd_stats($tag);
7981
let mut last_err = Ok(());
8082
for _ in 0..LEADER_CHANGE_RETRY {
8183
let res = $call;
8284

85+
#[cfg(feature = "prometheus")]
8386
match stats.done(res) {
8487
Ok(r) => return Ok(r),
8588
Err(e) => last_err = Err(e),
8689
}
90+
#[cfg(not(feature = "prometheus"))]
91+
match res {
92+
Ok(r) => return Ok(r),
93+
Err(e) => last_err = Err(e),
94+
}
8795

8896
let mut reconnect_count = MAX_REQUEST_COUNT;
8997
while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await {

src/request/plan.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ use crate::request::shard::HasNextBatch;
2121
use crate::request::NextBatch;
2222
use crate::request::Shardable;
2323
use crate::request::{KvRequest, StoreRequest};
24+
#[cfg(feature = "prometheus")]
2425
use crate::stats::tikv_stats;
2526
use crate::store::HasRegionError;
2627
use crate::store::HasRegionErrors;
@@ -60,13 +61,15 @@ impl<Req: KvRequest> Plan for Dispatch<Req> {
6061
type Result = Req::Response;
6162

6263
async fn execute(&self) -> Result<Self::Result> {
64+
#[cfg(feature = "prometheus")]
6365
let stats = tikv_stats(self.request.label());
6466
let result = self
6567
.kv_client
6668
.as_ref()
6769
.expect("Unreachable: kv_client has not been initialised in Dispatch")
6870
.dispatch(&self.request)
6971
.await;
72+
#[cfg(feature = "prometheus")]
7073
let result = stats.done(result);
7174
result.map(|r| {
7275
*r.downcast()

0 commit comments

Comments
 (0)