From bc654a968f59b9d5b1b08f239f88789a124656b9 Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Wed, 5 Feb 2025 10:41:25 +0100 Subject: [PATCH 1/2] use grid parent element to invoke blank element --- R/theme-defaults.R | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/R/theme-defaults.R b/R/theme-defaults.R index 7fe9742f5e..8cba921389 100644 --- a/R/theme-defaults.R +++ b/R/theme-defaults.R @@ -495,9 +495,8 @@ theme_classic <- function(base_size = 11, base_family = "", ) %+replace% theme( # no background and no grid - panel.border = element_blank(), - panel.grid.major = element_blank(), - panel.grid.minor = element_blank(), + panel.border = element_blank(), + panel.grid = element_blank(), # show axes axis.text = element_text(size = rel(0.8)), From f2086616e0fcf56ef79e41f87a80457a25c2cfad Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Wed, 5 Feb 2025 10:45:47 +0100 Subject: [PATCH 2/2] Tweak bullet with related changes --- NEWS.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS.md b/NEWS.md index 74b049ace5..2688855c60 100644 --- a/NEWS.md +++ b/NEWS.md @@ -270,8 +270,11 @@ is setup once in total instead of once per group (@teunbrand, #5971) * `facet_grid(space = "free")` can now be combined with `coord_fixed()` (@teunbrand, #4584). -* `theme_classic()` now has black ticks and text instead of dark gray. In - addition, `theme_classic()`'s axis line end is `"square"` (@teunbrand, #5978). +* `theme_classic()` has the following changes (@teunbrand, #5978 & #6320): + * Axis ticks are now black (`ink`-coloured) instead of dark gray. + * Axis line ends are now `"square"`. + * The panel grid is now blank at the `panel.grid` hierarchy level instead of + the `panel.grid.major` and `panel.grid.minor` levels. * {tibble} is now suggested instead of imported (@teunbrand, #5986) * The ellipsis argument is now checked in `fortify()`, `get_alt_text()`, `labs()` and several guides (@teunbrand, #3196).