From d8c96d8ca7ebb93f96b1f34ec700259f7b9637ea Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Mon, 2 Sep 2024 14:51:02 +0200 Subject: [PATCH 1/3] no space for blank ticks --- R/guide-axis.R | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/R/guide-axis.R b/R/guide-axis.R index bc2a2e1596..70ac3da43f 100644 --- a/R/guide-axis.R +++ b/R/guide-axis.R @@ -256,6 +256,12 @@ GuideAxis <- ggproto( override_elements = function(params, elements, theme) { elements$text <- label_angle_heuristic(elements$text, params$position, params$angle) + if (inherits(elements$ticks, "element_blank")) { + elements$major_length <- unit(0, "cm") + } + if (inherits(elements$minor, "element_blank") || isFALSE(params$minor.ticks)) { + elements$minor_length <- unit(0, "cm") + } return(elements) }, From 6c136a11ac98503af9be995c93a16219fa60e9f9 Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Tue, 3 Sep 2024 08:59:23 +0200 Subject: [PATCH 2/3] preserve axis text spacing for `theme_minimal()` --- R/theme-defaults.R | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/R/theme-defaults.R b/R/theme-defaults.R index 77b36e243e..4b88e203ff 100644 --- a/R/theme-defaults.R +++ b/R/theme-defaults.R @@ -436,7 +436,11 @@ theme_minimal <- function(base_size = 11, base_family = "", base_rect_size = base_rect_size ) %+replace% theme( - axis.ticks = element_blank(), + axis.ticks = element_blank(), # Extra margins due to absence ticks + axis.text.x.bottom = element_text(margin = margin(t = 0.45 * base_size)), + axis.text.x.top = element_text(margin = margin(b = 0.45 * base_size)), + axis.text.y.left = element_text(margin = margin(r = 0.45 * base_size)), + axis.text.y.right = element_text(margin = margin(l = 0.45 * base_size)), legend.background = element_blank(), legend.key = element_blank(), panel.background = element_blank(), From 895d5b2cb0321b261b09519234fde3629182e3e7 Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Tue, 3 Sep 2024 09:03:45 +0200 Subject: [PATCH 3/3] add news bullet --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index 40bdb3d156..2681c883ab 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # ggplot2 (development version) +* `guide_axis()` no longer reserves space for blank ticks + (@teunbrand, #4722, #6069). * `guide_bins()`, `guide_colourbar()` and `guide_coloursteps()` gain an `angle` argument to overrule theme settings, similar to `guide_axis(angle)` (@teunbrand, #4594).