From 01d86a11dcdebc91c321bfad36aca7285501746e Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Tue, 4 Jun 2024 09:44:39 +0200 Subject: [PATCH 1/3] pass missing arguments --- R/guide-colorsteps.R | 3 +++ 1 file changed, 3 insertions(+) diff --git a/R/guide-colorsteps.R b/R/guide-colorsteps.R index de10b51a04..52b6e1809d 100644 --- a/R/guide-colorsteps.R +++ b/R/guide-colorsteps.R @@ -52,6 +52,7 @@ guide_coloursteps <- function( even.steps = TRUE, show.limits = NULL, direction = NULL, + position = NULL, reverse = FALSE, order = 0, available_aes = c("colour", "color", "fill"), @@ -67,9 +68,11 @@ guide_coloursteps <- function( alpha = alpha, even.steps = even.steps, show.limits = show.limits, + position = position, direction = direction, reverse = reverse, order = order, + available_aes = available_aes, super = GuideColoursteps ) } From 4ecd836ae0ff94ce6fed2443c57e794d028672e9 Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Tue, 4 Jun 2024 10:02:14 +0200 Subject: [PATCH 2/3] document --- man/guide_coloursteps.Rd | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/man/guide_coloursteps.Rd b/man/guide_coloursteps.Rd index 97e66d6207..a2938df745 100644 --- a/man/guide_coloursteps.Rd +++ b/man/guide_coloursteps.Rd @@ -12,6 +12,7 @@ guide_coloursteps( even.steps = TRUE, show.limits = NULL, direction = NULL, + position = NULL, reverse = FALSE, order = 0, available_aes = c("colour", "color", "fill"), @@ -25,6 +26,7 @@ guide_colorsteps( even.steps = TRUE, show.limits = NULL, direction = NULL, + position = NULL, reverse = FALSE, order = 0, available_aes = c("colour", "color", "fill"), @@ -57,6 +59,9 @@ shown irrespective of the value of \code{show.limits}.} \item{direction}{A character string indicating the direction of the guide. One of "horizontal" or "vertical."} +\item{position}{A character string indicating where the legend should be +placed relative to the plot panels.} + \item{reverse}{logical. If \code{TRUE} the colourbar is reversed. By default, the highest value is on the top and the lowest value is on the bottom} From 52740339f605aa9c3f46a8a751856a0e203f8c09 Mon Sep 17 00:00:00 2001 From: Teun van den Brand Date: Thu, 11 Jul 2024 20:10:33 +0200 Subject: [PATCH 3/3] add news bullet --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index de3e87cee3..74dee619ea 100644 --- a/NEWS.md +++ b/NEWS.md @@ -90,6 +90,8 @@ the `nbin` argument (@teunbrand, #5882, #5036) * `after_stat()` and `after_scale()` throw warnings when the computed aesthetics are not of the correct length (#5901). +* `guide_colourbar()` now correctly hands off `position` and `available_aes` + parameters downstream (@teunbrand, #5930) # ggplot2 3.5.1