Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends #6364.
There are two workarounds we've used to make S7 work that, after some consideration, may not be necessary.
S7::method()
returning a function in the namespace that then clashed with S3 functions, we usedfunction_name.ggplot2::ggplot
and its ilk. Since then we learned of usinglocal()
to avoid this problem, and it is arguably a better solution than hacking away at S3 methods. Except for replacement functions, this seems to work great.build_ggplot()
forggplot_build()
This uses double dispatch that cannot be S3.update_ggplot()
forggplot_add()
draw_element()
forelement_grob()
gtable_ggplot()
forggplot_gtable()