Skip to content

fix: correct Rd link syntax for aesthetics roxygen2 tag #6538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

Yunuuuu
Copy link
Contributor

@Yunuuuu Yunuuuu commented Jul 2, 2025

fix #6537

@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Jul 2, 2025

Everything works well for me in this PR:
image

@teunbrand
Copy link
Collaborator

Does this look fine both when ggplot2 uses the @aesthetics tag and extensions use the @aesthetics tag?

@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Jul 2, 2025

Yeah, both work fine regarding the docs! I did notice a few errors in the ggplot2 R CMD check (not related to the docs):
image

Here is the error:
image

@teunbrand
Copy link
Collaborator

Thanks for confirming! Are the failures you see on your end just due to a testthat version <3.2.2? Because I don't see any of those failures in the GHA checks

@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Jul 2, 2025

Everyhing works well after updating testthat.

Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this contribution!

@teunbrand teunbrand merged commit d5ff3a6 into tidyverse:main Jul 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning message for @aesthetics roxygen2 tag
2 participants