Skip to content

Commit 8895ec2

Browse files
authored
Update CONTRIBUTING.md (#6030)
1 parent 7fb4c38 commit 8895ec2

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,20 +61,19 @@ Each of these steps are described in more detail below. This might feel
6161
overwhelming the first time you get set up, but it gets easier with practice.
6262
If you get stuck at any point, please reach out for help on the [ggplot2-dev](https://groups.google.com/forum/#!forum/ggplot2-dev) mailing list.
6363

64-
If you're not familiar with git or github, please start by reading <http://r-pkgs.had.co.nz/git.html>
64+
If you're not familiar with git or github, please start by reading <https://r-pkgs.org/software-development-practices.html>
6565

6666
<!--
6767
* [ ] Motivate the change in one paragraph, and include it in NEWS.
6868
In parentheses, reference your github user name and this issue:
6969
`(@hadley, #1234)`
7070
* [ ] Check pull request only includes relevant changes.
71-
* [ ] Use the [official style](http://adv-r.had.co.nz/Style.html).
71+
* [ ] Use the [official style](https://style.tidyverse.org).
7272
* [ ] Update documentation and re-run roxygen2
7373
* [ ] Add test, if bug in non-graphical function
7474
* [ ] Add visual test, if bug in graphical function
7575
* [ ] Add minimal example, if new graphical feature
7676
77-
See http://docs.ggplot2.org/dev/vignettes/development.html for more details.
7877
--->
7978

8079
Pull requests will be evaluated against a seven point checklist:
@@ -100,20 +99,16 @@ Pull requests will be evaluated against a seven point checklist:
10099
and don't submit any others until the first one has been processed.
101100

102101
1. __Use ggplot2 coding style__. Please follow the
103-
[official tidyverse style](http://style.tidyverse.org). Maintaining
102+
[official tidyverse style](https://style.tidyverse.org). Maintaining
104103
a consistent style across the whole code base makes it much easier to
105104
jump into the code. If you're modifying existing ggplot2 code that
106105
doesn't follow the style guide, a separate pull request to fix the
107106
style would be greatly appreciated.
108107

109108
1. If you're adding new parameters or a new function, you'll also need
110-
to document them with [roxygen](https://github.com/klutometis/roxygen).
109+
to document them with [roxygen2](https://github.com/r-lib/roxygen2).
111110
Make sure to re-run `devtools::document()` on the code before submitting.
112111

113-
Currently, ggplot2 uses the development version of roxygen2, which you
114-
can get with `install_github("klutometis/roxygen")`. This will be
115-
available on CRAN in the near future.
116-
117112
1. If fixing a bug or adding a new feature to a non-graphical function,
118113
please add a [testthat](https://github.com/r-lib/testthat) unit test.
119114

0 commit comments

Comments
 (0)