@@ -61,20 +61,19 @@ Each of these steps are described in more detail below. This might feel
61
61
overwhelming the first time you get set up, but it gets easier with practice.
62
62
If you get stuck at any point, please reach out for help on the [ ggplot2-dev] ( https://groups.google.com/forum/#!forum/ggplot2-dev ) mailing list.
63
63
64
- If you're not familiar with git or github, please start by reading < http ://r-pkgs.had.co.nz/git .html>
64
+ If you're not familiar with git or github, please start by reading < https ://r-pkgs.org/software-development-practices .html>
65
65
66
66
<!--
67
67
* [ ] Motivate the change in one paragraph, and include it in NEWS.
68
68
In parentheses, reference your github user name and this issue:
69
69
`(@hadley, #1234)`
70
70
* [ ] Check pull request only includes relevant changes.
71
- * [ ] Use the [official style](http ://adv-r.had.co.nz/Style.html ).
71
+ * [ ] Use the [official style](https ://style.tidyverse.org ).
72
72
* [ ] Update documentation and re-run roxygen2
73
73
* [ ] Add test, if bug in non-graphical function
74
74
* [ ] Add visual test, if bug in graphical function
75
75
* [ ] Add minimal example, if new graphical feature
76
76
77
- See http://docs.ggplot2.org/dev/vignettes/development.html for more details.
78
77
--->
79
78
80
79
Pull requests will be evaluated against a seven point checklist:
@@ -100,20 +99,16 @@ Pull requests will be evaluated against a seven point checklist:
100
99
and don't submit any others until the first one has been processed.
101
100
102
101
1 . __ Use ggplot2 coding style__ . Please follow the
103
- [ official tidyverse style] ( http ://style.tidyverse.org) . Maintaining
102
+ [ official tidyverse style] ( https ://style.tidyverse.org) . Maintaining
104
103
a consistent style across the whole code base makes it much easier to
105
104
jump into the code. If you're modifying existing ggplot2 code that
106
105
doesn't follow the style guide, a separate pull request to fix the
107
106
style would be greatly appreciated.
108
107
109
108
1 . If you're adding new parameters or a new function, you'll also need
110
- to document them with [ roxygen ] ( https://github.com/klutometis/roxygen ) .
109
+ to document them with [ roxygen2 ] ( https://github.com/r-lib/roxygen2 ) .
111
110
Make sure to re-run ` devtools::document() ` on the code before submitting.
112
111
113
- Currently, ggplot2 uses the development version of roxygen2, which you
114
- can get with ` install_github("klutometis/roxygen") ` . This will be
115
- available on CRAN in the near future.
116
-
117
112
1 . If fixing a bug or adding a new feature to a non-graphical function,
118
113
please add a [ testthat] ( https://github.com/r-lib/testthat ) unit test.
119
114
0 commit comments