Skip to content

Commit 4abac61

Browse files
committed
uppdate_(geom|stat)_defaults: don't manually class, add GeomPoint$default_aes to docs
1 parent 57c2a71 commit 4abac61

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

R/geom-defaults.r

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,16 @@
77
#' @keywords internal
88
#' @export
99
#' @examples
10-
#' update_geom_defaults("point", list(colour = "darkblue"))
10+
#' GeomPoint$default_aes
11+
#' update_geom_defaults("point", list(color = "red"))
12+
#' GeomPoint$default_aes
1113
#' ggplot(mtcars, aes(mpg, wt)) + geom_point()
1214
#' update_geom_defaults("point", list(colour = "black"))
1315
#' @rdname update_defaults
1416
update_geom_defaults <- function(geom, new) {
1517
g <- check_subclass(geom, "Geom", env = parent.frame())
1618
old <- g$default_aes
17-
g$default_aes <- defaults(rename_aes(new), old)
18-
class(g$default_aes) <- "uneval"
19+
g$default_aes[] <- defaults(rename_aes(new), old)[names(g$default_aes)]
1920
invisible()
2021
}
2122

@@ -24,7 +25,6 @@ update_geom_defaults <- function(geom, new) {
2425
update_stat_defaults <- function(stat, new) {
2526
g <- check_subclass(stat, "Stat", env = parent.frame())
2627
old <- g$default_aes
27-
g$default_aes <- defaults(rename_aes(new), old)
28-
class(g$default_aes) <- "uneval"
28+
g$default_aes[] <- defaults(rename_aes(new), old)[names(g$default_aes)]
2929
invisible()
3030
}

man/update_defaults.Rd

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)