Skip to content

Commit 3fda191

Browse files
committed
Tweaking checklist
1 parent e211426 commit 3fda191

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

vignettes/development.Rmd

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,14 @@ Pull requests will be evaluated against the following checklist:
103103

104104
```
105105
* [ ] Motivate the change in one paragraph, and include it in NEWS.
106-
Reference this issue and thank yourself.
106+
In parenthesis, reference your github user name and this issue:
107+
`(@hadley, #1234)`
107108
* [ ] Check pull request only includes relevant changes.
108109
* [ ] Use the [official style](http://adv-r.had.co.nz/Style.html).
109110
* [ ] Update documentation and re-run roxygen2
110111
* [ ] Add test, if bug in non-graphical function
112+
* [ ] Add visual test, if bug in graphical function
111113
* [ ] Add minimal example, if new graphical feature
112-
* [ ] Does not change existing behaviour
113114
```
114115

115116
These are explained in more detail below. This seems like a lot of work but don't worry if your pull request isn't perfect. It's a learning process and Winston and I will be on hand to help you out. A pull request is a process, and unless you've submitted a few in the past it's unlikely that your pull request will be accepted as is.

0 commit comments

Comments
 (0)