correct misleading error (#6043)

catalamarti · web-flow · commit 19d455025575 · 2024-08-15T14:31:59.000-07:00
diff --git a/R/utilities-break.R b/R/utilities-break.R
@@ -24,6 +24,9 @@
 #' table(cut_width(runif(1000), 0.1, center = 0))
 #' table(cut_width(runif(1000), 0.1, labels = FALSE))
 cut_interval <- function(x, n = NULL, length = NULL, ...) {
+  if ((!is.null(n) && !is.null(length)) || (is.null(n) && is.null(length))) {
+    cli::cli_abort("Specify exactly one of {.var n} and {.var length}.")
+  }
   cut(x, breaks(x, "width", n, length), include.lowest = TRUE, ...)
 }
 
diff --git a/tests/testthat/_snaps/utilities-break.md b/tests/testthat/_snaps/utilities-break.md
@@ -0,0 +1,4 @@
+# cut_interval gives the correct
+
+    Specify exactly one of `n` and `length`.
+
diff --git a/tests/testthat/test-utilities-break.R b/tests/testthat/test-utilities-break.R
@@ -0,0 +1,3 @@
+test_that("cut_interval throws the correct error message", {
+  expect_snapshot_error(cut_interval(x = 1:10, width = 10))
+})

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,9 @@`
`24`	`24`	`#' table(cut_width(runif(1000), 0.1, center = 0))`
`25`	`25`	`#' table(cut_width(runif(1000), 0.1, labels = FALSE))`
`26`	`26`	`cut_interval <- function(x, n = NULL, length = NULL, ...) {`
	`27`	`+ if ((!is.null(n) && !is.null(length)) \|\| (is.null(n) && is.null(length))) {`
	`28`	`+ cli::cli_abort("Specify exactly one of {.var n} and {.var length}.")`
	`29`	`+ }`
`27`	`30`	`cut(x, breaks(x, "width", n, length), include.lowest = TRUE, ...)`
`28`	`31`	`}`
`29`	`32`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +# cut_interval gives the correct
++
 +    Specify exactly one of `n` and `length`.
++
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+test_that("cut_interval throws the correct error message", {`
	`2`	`+ expect_snapshot_error(cut_interval(x = 1:10, width = 10))`
	`3`	`+})`