Bug-fix justification with angle in geom_label() (#5424)

aphalo · web-flow · commit 182405b1207b · 2023-10-04T11:23:01.000+02:00
Now that geom_label() supports rotation with angle, it is necessary to pass the angle as the third argument to compute_just() as it is done in geom_text() to ensure correct text justification.
diff --git a/R/geom-label.R b/R/geom-label.R
@@ -74,10 +74,10 @@ GeomLabel <- ggproto("GeomLabel", Geom,
 
     data <- coord$transform(data, panel_params)
     if (is.character(data$vjust)) {
-      data$vjust <- compute_just(data$vjust, data$y)
+      data$vjust <- compute_just(data$vjust, data$y, data$x, data$angle)
     }
     if (is.character(data$hjust)) {
-      data$hjust <- compute_just(data$hjust, data$x)
+      data$hjust <- compute_just(data$hjust, data$x, data$y, data$angle)
     }
     if (!inherits(label.padding, "margin")) {
       label.padding <- rep(label.padding, length.out = 4)

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,10 @@ GeomLabel <- ggproto("GeomLabel", Geom,`
`74`	`74`
`75`	`75`	`data <- coord$transform(data, panel_params)`
`76`	`76`	`if (is.character(data$vjust)) {`
`77`		`- data$vjust <- compute_just(data$vjust, data$y)`
	`77`	`+ data$vjust <- compute_just(data$vjust, data$y, data$x, data$angle)`
`78`	`78`	`}`
`79`	`79`	`if (is.character(data$hjust)) {`
`80`		`- data$hjust <- compute_just(data$hjust, data$x)`
	`80`	`+ data$hjust <- compute_just(data$hjust, data$x, data$y, data$angle)`
`81`	`81`	`}`
`82`	`82`	`if (!inherits(label.padding, "margin")) {`
`83`	`83`	`label.padding <- rep(label.padding, length.out = 4)`