Skip to content

Commit 0a841dc

Browse files
committed
Merge branch 'v3.3.0-rc' of https://github.com/tidyverse/ggplot2 into v3.3.0-rc
2 parents b0a19f1 + 8acb760 commit 0a841dc

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

R/guides-axis.r

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,18 @@ draw_axis <- function(break_positions, break_labels, axis_position, theme,
193193
# override label element parameters for rotation
194194
if (inherits(label_element, "element_text")) {
195195
label_overrides <- axis_label_element_overrides(axis_position, angle)
196-
# label_overrides is always an element_text(), but in order for the merge to
197-
# keep the new class, the override must also have the new class
198-
class(label_overrides) <- class(label_element)
199-
label_element <- merge_element(label_overrides, label_element)
196+
# label_overrides is an element_text, but label_element may not be;
197+
# to merge the two elements, we just copy angle, hjust, and vjust
198+
# unless their values are NULL
199+
if (!is.null(label_overrides$angle)) {
200+
label_element$angle <- label_overrides$angle
201+
}
202+
if (!is.null(label_overrides$hjust)) {
203+
label_element$hjust <- label_overrides$hjust
204+
}
205+
if (!is.null(label_overrides$vjust)) {
206+
label_element$vjust <- label_overrides$vjust
207+
}
200208
}
201209

202210
# conditionally set parameters that depend on axis orientation

0 commit comments

Comments
 (0)