A question about why it loadSegmentEntries here

[woodliu]

wal/wal.go

Line 782 in ebf7b52

if err = l.loadSegmentEntries(s); err != nil {

Hi , could you tell me why it loadSegmentEntries here, i didn't see where use the loaded s, thanks!

[yihuang]

it just reload the file content into memory and recalculate the positions, since the file is modified.

[yihuang]

But I guess it's equivalent to: I was wrong, we need loadSegmentEntries to reset the epos.

s.ebuf = ebuf
s.epos = epos

And I think it should always set the ebuf or call loadSegmentEntries unconditionally, otherwise, the content of s.ebuf is before the truncate. But it's not incorrect though, because in the end, it still will find the correct entry by index.
I was wrong again, if the segment is not the last segment, the cache is cleared anyway, I guess there's the invariant that the last segment is not included in the lruCache.