Skip to content

type parameter of RequestDataValueProcessor#processFieldValue shouldn't be null #280

@sakuna63

Description

@sakuna63

SpringValueTagProcessor could pass null value as type parameter of RequestDataValueProcessor#processFieldValue although type is defined as Nonnull parameter(not annotated @Nullable)in spring-framework.

https://github.com/thymeleaf/thymeleaf-spring/blob/3.1-master/thymeleaf-spring5/src/main/java/org/thymeleaf/spring5/processor/SpringValueTagProcessor.java#L103-L106

For example, when SpringValueTagProcessor process <option value="aaa">, type will be null (because option has no type attribute).

In the scenario like above example, i think IElementTag#getElementCompleteName should be used as type value.

I'll send small PR to fix this issue later.
thaks.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions