Skip to content

Dark mode brokes tables with specified colors #8992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
filip2cz opened this issue Mar 25, 2025 · 3 comments
Open
2 tasks done

Dark mode brokes tables with specified colors #8992

filip2cz opened this issue Mar 25, 2025 · 3 comments
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors

Comments

@filip2cz
Copy link

filip2cz commented Mar 25, 2025

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App

Thunderbird for Android

App version

9.0

Where did you get the app from?

F-Droid

Android version

15

Device model

Pixel 6a (Bluejay)

Steps to reproduce

Create table with defined colors (I anonymized one where I found this issue and uploaded it below in eml format and renamed it so I can upload it). These black lines can be seen on big display, but I was not able to see them on mobile phone several times.

email.eml.txt

Image
Image

Expected behavior

If dark mode is enabled, colors should change so it is visible.

Actual behavior

Black colors are still black and people like me miss their english test because table looks completely different :D

Logs

No response

@filip2cz filip2cz added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels Mar 25, 2025
@filip2cz filip2cz changed the title Dark mode brokes tables Dark mode brokes tables with specified colors Mar 25, 2025
@faeryqueenrs
Copy link

I had a similar issue with a plain text email I received that discussed "the highlighted paragraph" but no highlighting was shown in dark mode. I can't share a picture because it was confidential information, but it was all one color like the table above.

@kewisch
Copy link
Member

kewisch commented Apr 3, 2025

I could imagine we need to update the css for dark mode to use a luminance based approach and potentially enable algorithmic darkening: https://developer.android.com/develop/ui/views/layout/webapps/dark-theme

  • legacy/ui/legacy/src/main/java/com/fsck/k9/view/MessageWebView.kt
  • legacy/core/src/main/java/com/fsck/k9/message/html/DisplayHtml.kt

@kewisch kewisch added good first issue Ideal for newcomers to start contributing and removed unconfirmed Newly reported issues awaiting triage or confirmation labels Apr 3, 2025
@kewisch
Copy link
Member

kewisch commented Apr 3, 2025

I'm tentatively marking this as a good first issue, though I may be wrong. The investigation on what the issue is might well be good for someone to get started on though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

No branches or pull requests

3 participants