Target .NET 9 (#797)

thomhurst · web-flow · commit 324c0b66221a · 2024-12-01T02:21:10.000Z
* Target .NET 9

* .NET 9 SDK on Pipeline

* Tweak build

* Fix

* ReleaseNotes.md
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -51,7 +51,7 @@ jobs:
       - name: Setup .NET
         uses: actions/setup-dotnet@v4
         with:
-          dotnet-version: 8.0.x
+          dotnet-version: 9.0.x
       - name: Cache NuGet
         uses: actions/cache@v4
         with:
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project>
   <PropertyGroup>
-    <TargetFrameworks Condition="'$(TargetFrameworks)' == ''">net6.0;net8.0</TargetFrameworks>
+    <TargetFrameworks Condition="'$(TargetFrameworks)' == ''">net6.0;net8.0;net9.0</TargetFrameworks>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <LangVersion>preview</LangVersion>
@@ -23,8 +23,6 @@
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory).ruleset</CodeAnalysisRuleSet>
     <StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
     <AnalysisLevel>preview</AnalysisLevel>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <WarningsNotAsErrors>NU5104;NU1507;NU1903</WarningsNotAsErrors>
   </PropertyGroup>
   <ItemGroup>
     <None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="\" />
diff --git a/global.json b/global.json
@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.401",
+    "version": "9.0.100",
     "rollForward": "latestMinor",
     "allowPrerelease": false
   }
diff --git a/src/ModularPipelines.Build/Modules/RunUnitTestsModule.cs b/src/ModularPipelines.Build/Modules/RunUnitTestsModule.cs
@@ -26,7 +26,7 @@ public class RunUnitTestsModule : Module<CommandResult[]>
             {
                 Project = unitTestProjectFile.Path,
                 NoBuild = true,
-                Framework = "net8.0",
+                Framework = "net9.0",
                 Arguments = ["--coverage", "--coverage-output-format", "cobertura"],
                 Configuration = Configuration.Release,
                 EnvironmentVariables = new Dictionary<string, string?>
diff --git a/src/ModularPipelines.Build/ReleaseNotes.md b/src/ModularPipelines.Build/ReleaseNotes.md
@@ -0,0 +1 @@
+- Add target for .NET 9
diff --git a/test/ModularPipelines.Azure.UnitTests/ModularPipelines.Azure.UnitTests.csproj b/test/ModularPipelines.Azure.UnitTests/ModularPipelines.Azure.UnitTests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <OutputType>Exe</OutputType>
diff --git a/test/ModularPipelines.TestHelpers/ModularPipelines.TestHelpers.csproj b/test/ModularPipelines.TestHelpers/ModularPipelines.TestHelpers.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>
diff --git a/test/ModularPipelines.TestsForTests/ModularPipelines.TestsForTests.csproj b/test/ModularPipelines.TestsForTests/ModularPipelines.TestsForTests.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
diff --git a/test/ModularPipelines.UnitTests/Helpers/DotNetTestResultsTests.cs b/test/ModularPipelines.UnitTests/Helpers/DotNetTestResultsTests.cs
@@ -25,7 +25,7 @@ private class DotNetTestWithFailureModule : Module<CommandResult>
             return await context.DotNet().Test(new DotNetTestOptions
             {
                 ProjectSolutionDirectoryDllExe = testProject,
-                Framework = "net8.0",
+                Framework = "net9.0",
                 CommandLogging = CommandLogging.Error,
             }, token: cancellationToken);
         }
@@ -44,7 +44,7 @@ private class DotNetTestWithoutFailureModule : Module<CommandResult>
             {
                 ProjectSolutionDirectoryDllExe = testProject,
                 Filter = "TestCategory=Pass",
-                Framework = "net8.0",
+                Framework = "net9.0",
                 CommandLogging = CommandLogging.Error,
                 Logger = [$"trx;LogFileName={TrxFile}"]
             }, token: cancellationToken);
diff --git a/test/ModularPipelines.UnitTests/ModularPipelines.UnitTests.csproj b/test/ModularPipelines.UnitTests/ModularPipelines.UnitTests.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <IsPackable>false</IsPackable>
     <OutputType>Exe</OutputType>
   </PropertyGroup>
diff --git a/test/ModularPipelines.UnitTests/PipelineWriterTests.cs b/test/ModularPipelines.UnitTests/PipelineWriterTests.cs
@@ -46,7 +46,7 @@ public override async Task<GitHubPipelineFileWriterOptions> GetGitHubPipelineFil
                 PipelineProjectPath = RandomFilePath.Path!,
                 Environment = "${{ github.ref == 'refs/heads/main' && 'Production' || 'Pull Requests' }}",
                 CacheNuGet = true,
-                DotNetRunFramework = "net8.0",
+                DotNetRunFramework = "net9.0",
                 ValuesToMask =
                 [
                     "${{ secrets.DOTNET_FORMAT_PUSH_TOKEN }}", "${{ secrets.NuGet__ApiKey }}",
@@ -134,7 +134,7 @@ await Assert.That((await RandomFilePath.ReadAsync()).Trim()).
                                key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj') }}
                                restore-keys: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj') }}
                            - name: Run Pipeline
-                             run: dotnet run -c Release --framework net8.0 {{{RandomFilePath}}}
+                             run: dotnet run -c Release --framework net9.0 {{{RandomFilePath}}}
                              env:
                                DOTNET_ENVIRONMENT: ${{ github.ref == 'refs/heads/main' && 'Production' || 'Development' }}
                                NuGet__ApiKey: ${{ secrets.NuGet__ApiKey }}
diff --git a/test/ModularPipelines.UnitTests/TrxParsingTests.cs b/test/ModularPipelines.UnitTests/TrxParsingTests.cs
@@ -26,7 +26,7 @@ public class NUnitModule : Module<DotNetTestResult>
             await context.DotNet().Test(new DotNetTestOptions
             {
                 ProjectSolutionDirectoryDllExe = testProject,
-                Framework = "net8.0",
+                Framework = "net9.0",
                 CommandLogging = CommandLogging.Error,
                 Logger = [$"trx;logfilename={trxFile}"],
                 ThrowOnNonZeroExitCode = false

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"sdk": {`
`3`		`- "version": "8.0.401",`
	`3`	`+ "version": "9.0.100",`
`4`	`4`	`"rollForward": "latestMinor",`
`5`	`5`	`"allowPrerelease": false`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public class RunUnitTestsModule : Module<CommandResult[]>`
`26`	`26`	`{`
`27`	`27`	`Project = unitTestProjectFile.Path,`
`28`	`28`	`NoBuild = true,`
`29`		`- Framework = "net8.0",`
	`29`	`+ Framework = "net9.0",`
`30`	`30`	`Arguments = ["--coverage", "--coverage-output-format", "cobertura"],`
`31`	`31`	`Configuration = Configuration.Release,`
`32`	`32`	`EnvironmentVariables = new Dictionary<string, string?>`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ private class DotNetTestWithFailureModule : Module<CommandResult>`
`25`	`25`	`return await context.DotNet().Test(new DotNetTestOptions`
`26`	`26`	`{`
`27`	`27`	`ProjectSolutionDirectoryDllExe = testProject,`
`28`		`- Framework = "net8.0",`
	`28`	`+ Framework = "net9.0",`
`29`	`29`	`CommandLogging = CommandLogging.Error,`
`30`	`30`	`}, token: cancellationToken);`
`31`	`31`	`}`
`@@ -44,7 +44,7 @@ private class DotNetTestWithoutFailureModule : Module<CommandResult>`
`44`	`44`	`{`
`45`	`45`	`ProjectSolutionDirectoryDllExe = testProject,`
`46`	`46`	`Filter = "TestCategory=Pass",`
`47`		`- Framework = "net8.0",`
	`47`	`+ Framework = "net9.0",`
`48`	`48`	`CommandLogging = CommandLogging.Error,`
`49`	`49`	`Logger = [$"trx;LogFileName={TrxFile}"]`
`50`	`50`	`}, token: cancellationToken);`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public class NUnitModule : Module<DotNetTestResult>`
`26`	`26`	`await context.DotNet().Test(new DotNetTestOptions`
`27`	`27`	`{`
`28`	`28`	`ProjectSolutionDirectoryDllExe = testProject,`
`29`		`- Framework = "net8.0",`
	`29`	`+ Framework = "net9.0",`
`30`	`30`	`CommandLogging = CommandLogging.Error,`
`31`	`31`	`Logger = [$"trx;logfilename={trxFile}"],`
`32`	`32`	`ThrowOnNonZeroExitCode = false`