perccli2 is not supported

[akrus]

We have a couple of new servers where only perccli2 is working, the output is slightly different, so we're getting this error:
Can't use an undefined value as an ARRAY reference at /usr/lib/nagios/plugins/check_lsi_raid line 409.
https://github.com/thomas-krenn/check_lsi_raid/blob/master/check_lsi_raid#L409

This is the particular line that it doesn't like anymore:

0/1   RAID1 Optl  RW     NR,WB        NR,WB        3.492 TiB

And full output:

CLI Version = 008.0004.0000.0022 Apr 28, 2023
Operating system = Linux5.15.0-72-lowlatency
Controller = 0
Status = Success
Description = None


Virtual Drives :
==============

------------------------------------------------------------------
DG/VD TYPE  State Access CurrentCache DefaultCache      Size Name
------------------------------------------------------------------
0/1   RAID1 Optl  RW     NR,WB        NR,WB        3.492 TiB
------------------------------------------------------------------

Rec=Recovery|OfLn=OffLine|Pdgd=Partially Degraded|Dgrd=Degraded
Optl=Optimal|RO=Read Only|RW=Read Write|CurrentCache-Curent Cache Status
R=Read Ahead Always|NR=No Read Ahead|WB=WriteBack|
AWB=Always WriteBack|WT=WriteThrough|Access-Access Policy

[gschoenberger]

Can you post the plugin output with "-vvv"?

[akrus]

Unfortunately, it doesn't print anything else with -vvv and it seems that there are much more changes than I initially thought. I've tried commenting out this 'for' loop completely, now it shows this message:

Invalid StorCLI command! (/opt/MegaRAID/perccli2/perccli2 /c0/eall/sall show initialization nolog)

When running the actual command it shows this:

CLI Version = 008.0004.0000.0022 Apr 28, 2023
Operating system = Linux5.15.0-72-lowlatency
Status = Failure
Description = syntax error, unexpected TOKEN_UNKNOWN, expecting $end

Adding --nocleanlogs also doesn't help (show initialization doesn't work anyway).

After PDInitToCheck parts are commented out, it starts to work, but reports incorrect information:

Critical (BBU Crit, CV Crit) [BBU/CV_Present = Critical]
Used storcli commands:
- /opt/MegaRAID/perccli2/perccli2 /c0 show all
- /opt/MegaRAID/perccli2/perccli2 /c0/vall show all nolog
- /opt/MegaRAID/perccli2/perccli2 /c0/vall show init nolog
- /opt/MegaRAID/perccli2/perccli2 /c0/eall/sall show all nolog
- /opt/MegaRAID/perccli2/perccli2 /c0/eall/sall show rebuild nolog
Critical sensors:
        - BBU/CV_Present
Warning sensors:
CTR information:
        - :
                - Serial Number=319003B
                - Firmware Package Build=
                - Mfg Date=
                - Revision No=
                - Bios Version=
                - Firmware Version=8.0.0.200-00018-00084
LD information:
        - c0/v1:
                - ld=c0/v1
PD information:
BBU information:
                - BBU_Status=Critical
CV information:
                - CV_Status=Critical

E.g. for battery it shows:

Energy Pack Info :
================

---------------------------------------------------
Type    SubType Voltage(mV) Temperature(C) Status
---------------------------------------------------
Battery None           4075             26 Optimal
---------------------------------------------------

Here are the outputs for perccli2 commands:
https://paste.opensuse.org/2fdddbba52e6
https://paste.opensuse.org/9e938352b8a9
https://paste.opensuse.org/9ee7ce9b53d2
https://paste.opensuse.org/cea8c0e63b15
https://paste.opensuse.org/28c84c332a6e

[akrus]

So, just to sum it up, the output is different, some commands are missing and there is no visible replacement available.

1. output for virtual drives has changed as mentioned above, this is more or less easy to fix as it's 8 columns now instead of 9/10, column Cache is named CurrentCache, format has changed from NRWBD to NR,WB
2. perccli2 /c0/eall/sall show initialization doesn't exist anymore
3. perccli2 /c0/bbu doesn't exist anymore

Don't know if it's worth adapting check_lsi_raid to these changes or easier to fork and create a new one instead.

[gschoenberger]

Mh that's quit a lot.
Can you provide a patch with your changes?
I can try to integrate it to check_lsi_raid...