Run memory specs separately; Fix some rubocop issues

Author: thisismydesign

.github/workflows/ci.yml

@@ -20,6 +20,9 @@ jobs:
       - name: Test
         run: bundle exec rspec
 
+      - name: Memory test
+        run: bundle exec rspec --tag speed:slow
+
   lint:
     runs-on: ubuntu-latest
     timeout-minutes: 5

.rspec

@@ -1,2 +1,3 @@
 --format documentation
 --color
+--require spec_helper

json-streamer.gemspec

@@ -8,13 +8,14 @@ Gem::Specification.new do |spec|
   spec.authors = ['thisismydesign']
   spec.email = ['thisismydesign@users.noreply.github.com']
 
-  spec.summary = 'Utility to support JSON streaming allowing you to get data based on various criteria (key, nesting level, etc).'
+  spec.summary = 'Stream JSON data based on various criteria (key, nesting level, etc).'
   spec.homepage = 'https://github.com/thisismydesign/json-streamer'
   spec.license = 'MIT'
   spec.required_ruby_version = '>= 3.1.0'
 
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/thisismydesign/json-streamer'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -29,9 +30,5 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  # Because of `require_relative`
-  spec.required_ruby_version = '>= 1.9.2'
-
   spec.add_dependency 'json-stream'
-  spec.metadata['rubygems_mfa_required'] = 'true'
 end

lib/json/streamer/aggregator.rb

@@ -24,19 +24,19 @@ def key
         @aggregator.last[:key] unless @aggregator.last.nil?
       end
 
-      def key=(k)
-        @aggregator.last[:key] = k
+      def key=(param)
+        @aggregator.last[:key] = param
       end
 
       def value
         @aggregator.last[:value]
       end
 
-      def value=(d)
+      def value=(param)
         if array_level?
-          value << d
+          value << param
         else
-          value[key] = d
+          value[key] = param
         end
       end
 

spec/json/streamer/conditions_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.describe Json::Streamer::Conditions do
   let(:yield_level) { -1 }
   let(:yield_key) { nil }

spec/json/streamer/json_streamer_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_examples 'Json::Streamer::JsonStreamer' do
   let(:example_key) { 'key' }
   let(:example_value) { 'value' }

spec/json/streamer_memory_spec.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.describe Json::Streamer do
-  describe 'memory usage', speed: 'slow', type: 'memory' do
+  describe 'memory usage', speed: 'slow' do
     before do
       GC.start
       highlight('MEMORY USAGE TEST')

spec/json/streamer_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.describe Json::Streamer do
   describe '.parser' do
     it 'returns Json::Streamer::JsonStreamer instance' do

spec/spec_helper.rb

@@ -1,12 +1,7 @@
 # frozen_string_literal: true
 
-require 'bundler/setup'
-Bundler.setup
-
 require 'simplecov'
-SimpleCov.start do
-  add_filter 'spec'
-end
+SimpleCov.start
 
 require 'stringio'
 require 'json'
@@ -29,3 +24,17 @@ def highlight(msg)
 def current_memory_usage
   GetProcessMem.new.mb.round
 end
+
+RSpec.configure do |config|
+  # Enable flags like --only-failures and --next-failure
+  config.example_status_persistence_file_path = '.rspec_status'
+
+  # Disable RSpec exposing methods globally on `Module` and `main`
+  config.disable_monkey_patching!
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+
+  config.filter_run_excluding speed: 'slow'
+end