Release 1.7.8 (#332)

* Fix: TypeScript Definitions (#327)

Closes #324

* Enhancement: Add Eslint and Format (#328)

* Update node verision used in CI

* Add Eslint and consistent format

Closes #326

* Enhancement: Update bnc-sdk Dependency (#329)

Closes #325

* Fix: Moment.js Resolution (#331)

* Put resolutions to locked down version of momentjs

* Update yarn.lock

Closes #330

* Change to version 1.7.8

Author: lnbc1QWFyb24

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   test:
     docker:
-      - image: circleci/node:8.15-browsers
+      - image: circleci/node:10.18.1-browsers
     steps:
       - checkout
       - restore_cache:
@@ -18,7 +18,7 @@ jobs:
           key: v1-dependencies-{{ checksum "package.json" }}
   deploy_stage:
     docker:
-      - image: circleci/node:8.15-browsers
+      - image: circleci/node:10.18.1-browsers
         user: root
     steps:
       - checkout
@@ -30,7 +30,7 @@ jobs:
       - run: npm publish --dry-run
   deploy_prod:
     docker:
-      - image: circleci/node:8.15-browsers
+      - image: circleci/node:10.18.1-browsers
         user: root
     steps:
       - checkout
@@ -42,7 +42,7 @@ jobs:
       - run: npm publish
   deploy_demo:
     docker:
-      - image: circleci/node:8.15-browsers
+      - image: circleci/node:10.18.1-browsers
         user: root
     steps:
       - checkout

.eslintrc.js

@@ -0,0 +1,19 @@
+module.exports = {
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: 'module'
+  },
+  extends: [
+    'plugin:@typescript-eslint/recommended',
+    'prettier/@typescript-eslint',
+    'plugin:prettier/recommended'
+  ],
+
+  rules: {
+    '@typescript-eslint/no-use-before-define': 'off',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/no-empty-function': 'off'
+  }
+}

.prettierrc

@@ -0,0 +1,8 @@
+module.exports = {
+  semi: false,
+  trailingComma: 'none',
+  singleQuote: true,
+  printWidth: 80,
+  tabWidth: 2,
+  arrowParens: 'avoid'
+}

.prettierrc.js

@@ -1,6 +1,6 @@
 {
   "name": "bnc-onboard",
-  "version": "1.7.7",
+  "version": "1.7.8",
   "description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
   "keywords": [
     "ethereum",
@@ -19,6 +19,9 @@
     "type": "git",
     "url": "https://github.com/blocknative/onboard"
   },
+  "resolutions": {
+    "moment": "2.24.0"
+  },
   "license": "MIT",
   "devDependencies": {
     "@babel/cli": "^7.7.0",
@@ -29,7 +32,13 @@
     "@rollup/plugin-json": "^4.0.0",
     "@rollup/plugin-node-resolve": "^7.1.1",
     "@types/node": "^13.5.1",
+    "@typescript-eslint/eslint-plugin": "^2.30.0",
+    "@typescript-eslint/parser": "^2.30.0",
     "babel-plugin-external-helpers": "^6.18.0",
+    "eslint": "^6.8.0",
+    "eslint-config-prettier": "^6.11.0",
+    "eslint-plugin-prettier": "^3.1.3",
+    "prettier": "^2.0.5",
     "rimraf": "^3.0.0",
     "rollup": "^1.27.5",
     "rollup-plugin-svelte": "^5.0.3",
@@ -47,7 +56,7 @@
     "@walletconnect/web3-provider": "^1.0.0-beta.47",
     "authereum": "^0.0.4-beta.131",
     "bignumber.js": "^9.0.0",
-    "bnc-sdk": "2.0.0",
+    "bnc-sdk": "2.1.1",
     "bowser": "^2.5.2",
     "ethereumjs-tx": "^2.1.2",
     "ethereumjs-util": "^6.2.0",

package.json

@@ -10,7 +10,6 @@ declare module 'trezor-connect'
 declare module 'ethereumjs-tx'
 declare module 'ethereumjs-util'
 declare module 'hdkey'
-// declare module 'ethereumjs-wallet/hdkey'
 declare module '@ledgerhq/hw-app-eth'
 declare module '@ledgerhq/hw-transport-u2f'
 

src/@types/index.d.ts

@@ -97,8 +97,6 @@
         on:mouseenter={() => (closeHovered = true)}
         on:mouseleave={() => (closeHovered = false)}>
         <svg
-          version="1.1"
-          id="Capa_1"
           xmlns="http://www.w3.org/2000/svg"
           xmlns:xlink="http://www.w3.org/1999/xlink"
           x="0px"

src/components/Modal.svelte

@@ -1,6 +1,6 @@
 <script lang="ts">
-  import { app } from "../stores";
-  export let onclick: () => void = () => {};
+  import { app } from '../stores'
+  export let onclick: () => void = () => {}
 </script>
 
 <style>

src/elements/Button.svelte

@@ -1,4 +1,4 @@
-const walletIcon: string = `
+const walletIcon = `
 <svg
 height="18"
 viewBox="0 0 19 18"

src/elements/walletIcon.ts

@@ -1,18 +1,25 @@
 export interface Initialization {
   dappId: string
   networkId: number
-  subscriptions: Subscriptions
-  walletSelect: WalletSelectModule
-  walletCheck: Array<WalletCheckModule | WalletCheckInit>
+  subscriptions?: Subscriptions
+  walletSelect?: WalletSelectModuleOptions
+  walletCheck?: Array<WalletCheckModule | WalletCheckInit>
   darkMode?: boolean
   apiUrl?: string
 }
 
 export interface Subscriptions {
-  address: (address: string) => void
-  network: (networkId: number) => void
-  balance: (balance: string) => void
-  wallet: (wallet: Wallet) => void
+  address?: (address: string) => void
+  network?: (networkId: number) => void
+  balance?: (balance: string) => void
+  wallet?: (wallet: Wallet) => void
+}
+
+export interface WalletSelectModuleOptions {
+  heading?: string
+  description?: string
+  wallets?: Array<WalletModule | WalletInitOptions>
+  explanation?: string
 }
 
 export interface WalletSelectModule {
@@ -27,7 +34,6 @@ export interface WalletCheckModule {
     | WalletCheckModal
     | undefined
     | Promise<WalletCheckModal | undefined>
-  id?: string
 }
 
 export interface WalletCheckModule {
@@ -155,37 +161,37 @@ export interface Wallet {
 }
 
 export interface CommonWalletOptions {
-  networkId: number
+  walletName: string
   preferred?: boolean
   label?: string
   iconSrc?: string
   svg?: string
 }
 
-export interface SdkWalletOptions {
+export interface SdkWalletOptions extends CommonWalletOptions {
   apiKey: string
 }
 
-export interface WalletConnectOptions {
+export interface WalletConnectOptions extends CommonWalletOptions {
   infuraKey: string
   rpc: {
     [key: string]: string
   }
   bridge: string
 }
 
-export interface TrezorOptions {
+export interface TrezorOptions extends CommonWalletOptions {
   appUrl: string
   email: string
   rpcUrl: string
 }
 
-export interface LedgerOptions {
+export interface LedgerOptions extends CommonWalletOptions {
   rpcUrl: string
   LedgerTransport?: any
 }
 
-export interface TorusOptions {
+export interface TorusOptions extends CommonWalletOptions {
   loginMethod?: 'google' | 'facebook' | 'twitch' | 'reddit' | 'discord'
   buildEnv?: 'production' | 'development' | 'staging' | 'testing'
   showTorusButton?: boolean
@@ -202,22 +208,38 @@ interface TorusVerifierStatus {
   discord?: boolean
 }
 
-export interface AuthereumOptions {
+export interface AuthereumOptions extends CommonWalletOptions {
   disableNotifications?: boolean
 }
 
-interface WalletName {
-  walletName: string
+export interface ImTokenOptions extends CommonWalletOptions {
+  rpcUrl?: string
+}
+
+export interface TrustWalletOptions extends CommonWalletOptions {
+  rpcUrl?: string
 }
 
-export type WalletInitOptions = CommonWalletOptions &
+export type WalletInitOptions =
+  | CommonWalletOptions
+  | SdkWalletOptions
+  | WalletConnectOptions
+  | TorusOptions
+  | TrezorOptions
+  | AuthereumOptions
+  | LedgerOptions
+  | ImTokenOptions
+  | TrustWalletOptions
+
+export type AllWalletInitOptions = CommonWalletOptions &
   SdkWalletOptions &
   WalletConnectOptions &
   TorusOptions &
   TrezorOptions &
   AuthereumOptions &
   LedgerOptions &
-  WalletName
+  ImTokenOptions &
+  TrustWalletOptions & { networkId: number }
 
 export interface WalletCheckInit {
   checkName: string