[core-v2.8.4-alpha.1, react-v2.3.4-alpha.1, vue-v2.2.4-alpha.1]: Fix - AC UI balance & rpcUrl whitespace bug (#1270)

* refine styling
* Bump vue and react
* Revert size change
* Update github issue templates

Author: Adamj1232

.github/ISSUE_TEMPLATE/BUG.yml

@@ -6,7 +6,6 @@ assignees:
   - taylorjdawson
   - aaronbarnardsound
   - Adamj1232
-  - mahmud-bn
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/FEATURE.yml

@@ -5,6 +5,7 @@ labels: [feature]
 assignees:
   - taylorjdawson
   - aaronbarnardsound
+  - Adamj1232
 body:
   - type: markdown
     attributes:

packages/core/src/store/actions.ts

@@ -64,10 +64,11 @@ export function addChains(chains: Chain[]): void {
   // chains are validated on init
   const action = {
     type: ADD_CHAINS,
-    payload: chains.map(({ namespace = 'evm', id, ...rest }) => ({
+    payload: chains.map(({ namespace = 'evm', id, rpcUrl, ...rest }) => ({
       ...rest,
       namespace,
-      id: id.toLowerCase()
+      id: id.toLowerCase(),
+      rpcUrl: rpcUrl.trim()
     }))
   }
 

packages/core/src/views/account-center/Maximized.svelte

@@ -13,7 +13,7 @@
   import WalletAppBadge from '../shared/WalletAppBadge.svelte'
   import { getDefaultChainStyles, unrecognizedChainStyle } from '../../utils.js'
   import SuccessStatusIcon from '../shared/SuccessStatusIcon.svelte'
-  import NetworkBadgeSelector from '../shared/NetworkSelector.svelte'
+  import NetworkSelector from '../shared/NetworkSelector.svelte'
   import caretLightIcon from '../../icons/caret-light.js'
   import warningIcon from '../../icons/warning.js'
   import questionIcon from '../../icons/question.js'
@@ -137,6 +137,7 @@
 
   .network-selector-container {
     margin-left: 1rem;
+    width: 100%;
   }
 
   .network-selector-label {
@@ -336,12 +337,13 @@
               default: en.accountCenter.currentNetwork
             })}
           </div>
-          <div on:click class="flex items-center">
-            <NetworkBadgeSelector
+          <div on:click class="flex items-center" style=" width: 100%;">
+            <NetworkSelector
               chains={appChains}
               colorVar="--account-center-maximized-network-selector-color"
               bold={true}
               selectIcon={caretLightIcon}
+              parentCSSId="maximized_ac"
             />
           </div>
         </div>

packages/core/src/views/account-center/Minimized.svelte

@@ -90,10 +90,14 @@
     font-weight: 400;
     line-height: var(--onboard-font-line-height-2, var(--font-line-height-2));
     color: var(--onboard-gray-400, var(--gray-400));
+    overflow: hidden;
+    white-space: nowrap;
+    text-overflow: ellipsis;
+    width: 7.25rem;
   }
 
   .network {
-    margin-left: 0.5rem;
+    margin-left: 0.2rem;
   }
 
   .chain-icon {
@@ -210,6 +214,7 @@
             {chains}
             colorVar="--account-center-minimized-network-selector-color"
             selectIcon={caretIcon}
+            parentCSSId="minimized_ac"
           />
         </div>
       </div>

packages/core/src/views/account-center/WalletRow.svelte

@@ -97,11 +97,15 @@
     margin-left: 0.5rem;
     color: var(--onboard-gray-300, var(--gray-300));
     transition: color 150ms ease-in-out, background-color 150ms ease-in-out;
+    overflow: hidden;
+    white-space: nowrap;
+    text-overflow: ellipsis;
+    width: 7.25rem;
   }
 
   .elipsis-container {
     padding: 0.25rem;
-    margin-left: 0.5rem;
+    margin-left: 0.25rem;
     border-radius: 24px;
     transition: color 150ms ease-in-out, background-color 150ms ease-in-out;
     background-color: transparent;

packages/core/src/views/shared/NetworkSelector.svelte

@@ -11,6 +11,7 @@
   export let colorVar: string
   export let chains: Chain[]
   export let bold = false
+  export let parentCSSId = ''
 
   const switching$ = new BehaviorSubject<boolean>(false)
   let selectElement: HTMLSelectElement
@@ -73,39 +74,50 @@
     appearance: none;
     font-size: var(--onboard-font-size-7, var(--font-size-7));
     line-height: var(--onboard-font-line-height-3, var(--font-line-height-3));
-    max-width: 90px;
-    min-width: 72px;
     transition: width 250ms ease-in-out;
     background-repeat: no-repeat, repeat;
     background-position: right 0px top 0px, 0 0;
     scrollbar-width: none;
     -ms-overflow-style: none;
-    padding: 0 16px 0 0;
+    padding: 0 14px 0 0;
+    white-space: nowrap;
+    text-overflow: ellipsis;
+  }
+
+  select.minimized_ac {
+    min-width: 80px;
+    max-width: 80px;
+  }
+
+  select.maximized_ac {
+    width: auto !important;
   }
 
   select:focus {
     outline: none;
   }
 
-  span {
+  span.switching-placeholder {
     font-size: var(--onboard-font-size-7, var(--font-size-7));
     line-height: var(--onboard-font-line-height-3, var(--font-line-height-3));
+    min-width: 80px;
+    max-width: 80px;
+    padding: 0 8px 0 4px;
   }
 </style>
 
 {#if wallet}
   {#if $switching$}
     <span
+      class={`switching-placeholder ${parentCSSId}`}
       style={`
         color: var(${colorVar}, 
         var(--account-center-network-selector-color, var (--gray-500))); 
-        padding: 0 8px 0 4px;
-      `}
-      >switching...</span
+      `}>switching...</span
     >
   {:else}
     <select
-      class="flex justify-center items-center pointer"
+      class={`flex justify-center items-center pointer ${parentCSSId}`}
       bind:this={selectElement}
       value={wallet.chains[0].id}
       on:change={handleSelect}

packages/react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/react",
-  "version": "2.3.3",
+  "version": "2.3.4-alpha.1",
   "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",

packages/vue/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/vue",
-  "version": "2.2.3",
+  "version": "2.2.4-alpha.1",
   "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",

yarn.lock

@@ -2953,25 +2953,6 @@
   dependencies:
     "@walletconnect/window-getters" "^1.0.0"
 
-"@web3-onboard/core@^2.8.2":
-  version "2.8.2"
-  resolved "https://registry.yarnpkg.com/@web3-onboard/core/-/core-2.8.2.tgz#70d1730384a3e028bbe07769086361db5c631d78"
-  integrity sha512-AE2xQVKsmjtvW7lI7xFFdfAtoLxmZRa9qfCv5MtHRDY9Ojqkj06dLgteJmB4FBFZnh79iXoKbIj7N+vRpvjHIw==
-  dependencies:
-    "@web3-onboard/common" "^2.2.2"
-    bignumber.js "^9.0.0"
-    bnc-sdk "^4.4.1"
-    bowser "^2.11.0"
-    ethers "5.5.3"
-    eventemitter3 "^4.0.7"
-    joi "17.6.0"
-    lodash.merge "^4.6.2"
-    lodash.partition "^4.6.0"
-    nanoid "^4.0.0"
-    rxjs "^7.5.2"
-    svelte "^3.49.0"
-    svelte-i18n "^3.3.13"
-
 "@web3auth/base-plugin@^1.0.1":
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/@web3auth/base-plugin/-/base-plugin-1.0.1.tgz#1e2a87acf745299fdff6f92e6c46ee9bc38aa670"