Skip to content

Commit b813485

Browse files
committed
Merge branch 'develop' into feature/hardware-wallets
2 parents d17330a + 9a07795 commit b813485

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

src/components/Wallets.svelte

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<script lang="ts">
22
import { onDestroy } from 'svelte'
3-
import { fade } from 'svelte/transition'
43
import Button from '../elements/Button.svelte'
54
import IconButton from '../elements/IconButton.svelte'
65
import { wallet } from '../stores'
@@ -29,10 +28,7 @@
2928
align-items: center;
3029
list-style-type: none;
3130
margin: 1.25em 0;
32-
max-height: 66vh;
33-
overflow-y: scroll;
3431
padding: 0;
35-
scrollbar-width: none;
3632
font-family: inherit;
3733
font-size: inherit;
3834
line-height: 1.15;
@@ -62,14 +58,15 @@
6258
}
6359
6460
ul {
65-
scrollbar-width: unset;
61+
max-height: 66vh;
62+
overflow-y: scroll;
6663
}
6764
}
6865
</style>
6966

7067
<ul class="bn-onboard-custom bn-onboard-modal-select-wallets">
71-
{#each modalData.primaryWallets as wallet}
72-
<li in:fade>
68+
{#each modalData.primaryWallets as wallet, i (wallet.name)}
69+
<li>
7370
<IconButton
7471
onclick={() => handleWalletSelect(wallet)}
7572
iconSrc={wallet.iconSrc}
@@ -90,8 +87,8 @@
9087
{/if}
9188

9289
{#if showingAllWalletModules}
93-
{#each modalData.secondaryWallets as wallet}
94-
<li in:fade>
90+
{#each modalData.secondaryWallets as wallet, i (wallet.name)}
91+
<li>
9592
<IconButton
9693
onclick={() => handleWalletSelect(wallet)}
9794
iconSrc={wallet.iconSrc}

src/modules/select/wallets/metamask.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ function metamask(options: CommonWalletOptions): WalletModule {
3737
link: 'https://metamask.io/',
3838
installMessage: extensionInstallMessage,
3939
desktop: true,
40+
mobile: true,
4041
preferred
4142
}
4243
}

src/views/WalletSelect.svelte

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -67,31 +67,33 @@
6767
return !osExclusions.includes(os)
6868
})
6969
70+
if (deviceWallets.find(wallet => wallet.preferred)) {
71+
// if preferred wallets, then split in to preferred and not preferred
72+
primaryWallets = deviceWallets.filter(wallet => wallet.preferred)
73+
secondaryWallets = deviceWallets.filter(wallet => !wallet.preferred)
74+
} else {
75+
// otherwise make the first 4 wallets preferred
76+
primaryWallets = deviceWallets.slice(0, 4)
77+
secondaryWallets =
78+
deviceWallets.length > 4 ? deviceWallets.slice(4) : undefined
79+
}
80+
81+
modalData = {
82+
heading,
83+
description,
84+
primaryWallets,
85+
secondaryWallets
86+
}
87+
7088
if (appState.autoSelectWallet) {
7189
const module = deviceWallets.find(
7290
(m: WalletModule) => m.name === appState.autoSelectWallet
7391
)
7492
7593
app.update(store => ({ ...store, autoSelectWallet: '' }))
7694
77-
module ? handleWalletSelect(module) : finish({ completed: false })
78-
} else {
79-
if (deviceWallets.find(wallet => wallet.preferred)) {
80-
// if preferred wallets, then split in to preferred and not preferred
81-
primaryWallets = deviceWallets.filter(wallet => wallet.preferred)
82-
secondaryWallets = deviceWallets.filter(wallet => !wallet.preferred)
83-
} else {
84-
// otherwise make the first 4 wallets preferred
85-
primaryWallets = deviceWallets.slice(0, 4)
86-
secondaryWallets =
87-
deviceWallets.length > 4 ? deviceWallets.slice(4) : undefined
88-
}
89-
90-
modalData = {
91-
heading,
92-
description,
93-
primaryWallets,
94-
secondaryWallets
95+
if (module) {
96+
handleWalletSelect(module)
9597
}
9698
}
9799
}

0 commit comments

Comments
 (0)