Fix typeof check for notify in core (#1106)

benjaminreid · Adamj1232 · web-flow · commit a9e267f73e9a · 2022-06-29T08:42:26.000-06:00
* Fix typeof check for notify in core

* Bump version

* Update packages/core/package.json

Co-authored-by: Adam Carpenter &lt;adamcarpenter86@gmail.com&gt;

Co-authored-by: Adam Carpenter &lt;adamcarpenter86@gmail.com&gt;
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/core",
-  "version": "2.3.1",
+  "version": "2.3.2-alpha.1",
   "scripts": {
     "build": "rollup -c",
     "dev": "rollup -c -w",
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -103,7 +103,7 @@ function init(options: InitOptions): OnboardAPI {
   }
 
   // update notify
-  if (typeof notify !== undefined) {
+  if (typeof notify !== 'undefined') {
     if ('desktop' in notify || 'mobile' in notify) {
       const error = validateNotifyOptions(notify)
   

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web3-onboard/core",`
`3`		`- "version": "2.3.1",`
	`3`	`+ "version": "2.3.2-alpha.1",`
`4`	`4`	`"scripts": {`
`5`	`5`	`"build": "rollup -c",`
`6`	`6`	`"dev": "rollup -c -w",`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ function init(options: InitOptions): OnboardAPI {`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`// update notify`
`106`		`- if (typeof notify !== undefined) {`
	`106`	`+ if (typeof notify !== 'undefined') {`
`107`	`107`	`if ('desktop' in notify \|\| 'mobile' in notify) {`
`108`	`108`	`const error = validateNotifyOptions(notify)`
`109`	`109`