Skip to content

Commit 989236f

Browse files
authored
[fix] - Provider Types (#869)
* Add generic request type to EIP1193Provider * Export EIP1193 type * Ignore WalletConnect any type mismatch * Add type check script to all modules and add to CI * Increment versions
1 parent 4fe6cf7 commit 989236f

File tree

21 files changed

+31
-20
lines changed

21 files changed

+31
-20
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ commands:
8787
name: Build
8888
command: |
8989
yarn
90+
yarn type-check
9091
yarn build
9192
- *save-cache
9293
- *create-npm-config

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
"install-m1-mac": "yarn install --ignore-optional",
99
"format": "prettier --write 'packages/**/*.ts'",
1010
"dev": "yarn wsrun dev",
11-
"build": "yarn wsrun build"
11+
"build": "yarn wsrun build",
12+
"type-check": "yarn wsrun type-check"
1213
},
1314
"devDependencies": {
1415
"prettier": "^2.4.1",

packages/common/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/common",
3-
"version": "2.0.1",
3+
"version": "2.0.2",
44
"scripts": {
55
"build": "rollup -c",
66
"dev": "rollup -c -w",

packages/common/src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,7 @@ export interface EIP1193Provider extends SimpleEventEmitter {
384384
request(args: EthSignTransactionRequest): Promise<string>
385385
request(args: EthSignMessageRequest): Promise<string>
386386
request(args: EIP712Request): Promise<string>
387+
request(args: { method: string; params?: Array<unknown> }): Promise<unknown>
387388
disconnect?(): void
388389
}
389390

packages/core/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"name": "@web3-onboard/core",
3-
"version": "2.0.6",
3+
"version": "2.0.7",
44
"scripts": {
55
"build": "rollup -c",
66
"dev": "rollup -c -w",
77
"start": "sirv public --no-clear",
8-
"typescript": "svelte-check --tsconfig ./tsconfig.json",
8+
"type-check": "svelte-check --tsconfig ./tsconfig.json",
99
"lint": "eslint -c './.eslintrc.cjs' './src' && prettier --check './src/**/*'"
1010
},
1111
"typings": "dist/index.d.ts",
@@ -40,7 +40,7 @@
4040
"typescript": "^4.5.5"
4141
},
4242
"dependencies": {
43-
"@web3-onboard/common": "^2.0.1",
43+
"@web3-onboard/common": "^2.0.2",
4444
"bowser": "^2.11.0",
4545
"ethers": "5.5.3",
4646
"eventemitter3": "^4.0.7",

packages/core/src/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ export type {
2929
ConnectedChain
3030
} from './types'
3131

32+
export type { EIP1193Provider } from '@web3-onboard/common'
33+
3234
function init(options: InitOptions): OnboardAPI {
3335
if (typeof window === 'undefined') return API
3436

packages/demo/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
"license": "MIT",
4040
"scripts": {
4141
"build": "cross-env NODE_ENV=production webpack",
42-
"dev": "webpack serve"
42+
"dev": "webpack serve",
43+
"type-check": "exit 0"
4344
}
4445
}

packages/fortmatic/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/gnosis/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/injected/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"test": "ava",
17+
"type-check": "tsc --noEmit"
1718
},
1819
"license": "MIT",
1920
"devDependencies": {

packages/keepkey/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"scripts": {
1717
"build": "tsc",
1818
"dev": "tsc -w",
19-
"test": "ava"
19+
"type-check": "tsc --noEmit"
2020
},
2121
"license": "MIT",
2222
"devDependencies": {

packages/keystone/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"scripts": {
1212
"build": "tsc",
1313
"dev": "tsc -w",
14-
"test": "ava"
14+
"type-check": "tsc --noEmit"
1515
},
1616
"license": "MIT",
1717
"devDependencies": {

packages/ledger/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/mew/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/portis/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/torus/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/trezor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/walletconnect/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

packages/walletconnect/src/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,11 @@ function walletConnect(options?: WalletConnectOptions): WalletInit {
224224
)
225225
}
226226

227-
return this.providers[chainId].send(method, params)
227+
return this.providers[chainId].send(
228+
method,
229+
// @ts-ignore
230+
params
231+
)
228232
}
229233
}
230234
}

packages/walletlink/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "tsc",
1515
"dev": "tsc -w",
16-
"test": "ava"
16+
"type-check": "tsc --noEmit"
1717
},
1818
"license": "MIT",
1919
"devDependencies": {

0 commit comments

Comments
 (0)