Skip to content

Commit 7aee118

Browse files
authored
[coinbase, react, injected] : Updates - Remove mobile check, version bump for affected packages and update Docs (#1010)
* Update version for injected wallets to get coinbase * Update coinbase package to remove mobile check * Update docs to reflect Coinbase package in favor of deprecated walletlink
1 parent be4c475 commit 7aee118

File tree

5 files changed

+50
-51
lines changed

5 files changed

+50
-51
lines changed

packages/coinbase/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/coinbase",
3-
"version": "2.0.3-alpha.1",
3+
"version": "2.0.3-alpha.2",
44
"description": "Coinbase Wallet module for web3-onboard",
55
"module": "dist/index.js",
66
"browser": "dist/index.js",

packages/coinbase/src/index.ts

Lines changed: 43 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -5,53 +5,52 @@ function coinbaseWallet({
55
}: {
66
darkMode?: boolean
77
} = {}): WalletInit {
8-
return ({ device }) =>
9-
device.type === 'mobile'
10-
? {
11-
label: 'Coinbase Wallet',
12-
getIcon: async () => (await import('./icon.js')).default,
13-
getInterface: async ({ chains, appMetadata }) => {
14-
const [chain] = chains
15-
const { name, icon } = appMetadata || {}
16-
17-
const { CoinbaseWalletSDK } = await import('@coinbase/wallet-sdk')
18-
19-
const base64 = window.btoa(icon || '')
20-
const appLogoUrl = `data:image/svg+xml;base64,${base64}`
21-
22-
const instance = new CoinbaseWalletSDK({
23-
appName: name || '',
24-
appLogoUrl,
25-
darkMode
26-
})
27-
28-
const coinbaseWalletProvider = instance.makeWeb3Provider(
29-
chain.rpcUrl,
30-
parseInt(chain.id)
31-
)
32-
33-
// patch the chainChanged event
34-
const on = coinbaseWalletProvider.on.bind(coinbaseWalletProvider)
35-
coinbaseWalletProvider.on = (event, listener) => {
36-
on(event, val => {
37-
if (event === 'chainChanged') {
38-
listener(`0x${(val as number).toString(16)}`)
39-
return
40-
}
41-
42-
listener(val)
43-
})
44-
45-
return coinbaseWalletProvider
8+
return () => {
9+
return {
10+
label: 'Coinbase Wallet',
11+
getIcon: async () => (await import('./icon.js')).default,
12+
getInterface: async ({ chains, appMetadata }) => {
13+
const [chain] = chains
14+
const { name, icon } = appMetadata || {}
15+
16+
const { CoinbaseWalletSDK } = await import('@coinbase/wallet-sdk')
17+
18+
const base64 = window.btoa(icon || '')
19+
const appLogoUrl = `data:image/svg+xml;base64,${base64}`
20+
21+
const instance = new CoinbaseWalletSDK({
22+
appName: name || '',
23+
appLogoUrl,
24+
darkMode
25+
})
26+
27+
const coinbaseWalletProvider = instance.makeWeb3Provider(
28+
chain.rpcUrl,
29+
parseInt(chain.id)
30+
)
31+
32+
// patch the chainChanged event
33+
const on = coinbaseWalletProvider.on.bind(coinbaseWalletProvider)
34+
coinbaseWalletProvider.on = (event, listener) => {
35+
on(event, val => {
36+
if (event === 'chainChanged') {
37+
listener(`0x${(val as number).toString(16)}`)
38+
return
4639
}
4740

48-
return {
49-
provider: coinbaseWalletProvider,
50-
instance
51-
}
52-
}
41+
listener(val)
42+
})
43+
44+
return coinbaseWalletProvider
45+
}
46+
47+
return {
48+
provider: coinbaseWalletProvider,
49+
instance
5350
}
54-
: null
51+
}
52+
}
53+
}
5554
}
5655

5756
export default coinbaseWallet

packages/core/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Install the core module:
1010

1111
If you would like to support all wallets, then you can install all of the wallet modules:
1212

13-
`npm i @web3-onboard/injected-wallets @web3-onboard/ledger @web3-onboard/trezor @web3-onboard/keepkey @web3-onboard/walletconnect @web3-onboard/walletlink @web3-onboard/torus @web3-onboard/portis @web3-onboard/mew @web3-onboard/gnosis @web3-onboard/magic @web3-onboard/fortmatic`
13+
`npm i @web3-onboard/injected-wallets @web3-onboard/coinbase @web3-onboard/ledger @web3-onboard/trezor @web3-onboard/keepkey @web3-onboard/walletconnect @web3-onboard/torus @web3-onboard/portis @web3-onboard/mew @web3-onboard/gnosis @web3-onboard/magic @web3-onboard/fortmatic`
1414

1515
Note:
1616

packages/injected/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/injected-wallets",
3-
"version": "2.0.6",
3+
"version": "2.0.7-alpha.1",
44
"description": "Injected wallets module for web3-onboard",
55
"module": "dist/index.js",
66
"browser": "dist/index.js",

packages/react/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@ import {
1717
useWallets
1818
} from '@web3-onboard/react'
1919
import injectedModule from '@web3-onboard/injected-wallets'
20+
import coinbaseModule from '@web3-onboard/coinbase'
2021
import trezorModule from '@web3-onboard/trezor'
2122
import ledgerModule from '@web3-onboard/ledger'
2223
import walletConnectModule from '@web3-onboard/walletconnect'
23-
import walletLinkModule from '@web3-onboard/walletlink'
2424
import portisModule from '@web3-onboard/portis'
2525
import fortmaticModule from '@web3-onboard/fortmatic'
2626
import torusModule from '@web3-onboard/torus'
2727
import keepkeyModule from '@web3-onboard/keepkey'
2828

2929
const injected = injectedModule()
30-
const walletLink = walletLinkModule()
30+
const coinbase = coinbaseModule()
3131
const walletConnect = walletConnectModule()
3232

3333
const portis = portisModule({
@@ -51,12 +51,12 @@ const trezor = trezorModule(trezorOptions)
5151

5252
const web3Onboard = init({
5353
wallets: [
54+
injected,
55+
coinbase,
5456
ledger,
5557
trezor,
5658
walletConnect,
5759
keepkey,
58-
walletLink,
59-
injected,
6060
fortmatic,
6161
portis,
6262
torus

0 commit comments

Comments
 (0)