Skip to content

Commit 76163dd

Browse files
committed
Fixes type error and adds CI
1 parent ebee2a0 commit 76163dd

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

.circleci/config.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,12 @@ jobs:
185185
working_directory: ~/web3-onboard-monorepo/packages/react
186186
steps:
187187
- node-build-steps
188+
build-magic:
189+
docker:
190+
- image: cimg/node:16.13.1
191+
working_directory: ~/web3-onboard-monorepo/packages/magic
192+
steps:
193+
- node-build-steps
188194

189195
workflows:
190196
version: 2
@@ -249,3 +255,7 @@ workflows:
249255
jobs:
250256
- build-react:
251257
<<: *deploy_production_filters
258+
magic:
259+
jobs:
260+
- build-magic:
261+
<<: *deploy_production_filters

packages/magic/src/login-modal.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@ const loginModal = async (options: LoginOptions): Promise<boolean> => {
2222

2323
loggedIn$.pipe(take(1)).subscribe(() => {
2424
app.$destroy()
25-
document.body.removeChild(
26-
document.body.querySelector('onboard-magic-login-modal')
27-
)
25+
const modalEl = document.body.querySelector('onboard-magic-login-modal')
26+
modalEl && document.body.removeChild(modalEl)
2827
})
2928

3029
return firstValueFrom(loggedIn$)

0 commit comments

Comments
 (0)