Merge pull request #110 from blocknative/develop

Release 1.0.3

Author: lnbc1QWFyb24

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bnc-onboard",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
   "keywords": [
     "ethereum",

src/interfaces.ts

@@ -33,17 +33,15 @@ export interface WalletCheckModule {
 }
 
 export interface WalletCheckModal {
-  img?: string
   heading: string
   description: string
   button?: {
     onclick: () => void
     text: string
   }
-  invalidMsg?: string
   eventCode: string
   action?: () => Promise<{ message: string } | undefined>
-  loading?: () => Promise<undefined>
+  loading?: Promise<undefined>
   icon?: string
 }
 
@@ -104,7 +102,7 @@ export interface WalletInterface {
   name: string
   connect?: () => Promise<{ message: string } | undefined>
   disconnect?: () => void
-  loading?: () => Promise<undefined>
+  loading?: Promise<undefined>
   address: StateSyncer
   network: StateSyncer
   balance: StateSyncer
@@ -120,7 +118,7 @@ export interface Wallet {
   provider: any
   instance?: any
   connect?: () => Promise<{ message: string } | undefined>
-  loading?: () => Promise<undefined>
+  loading?: Promise<undefined>
 }
 
 export interface SdkWalletOptions {

src/modules/select/wallets/authereum.ts

@@ -37,10 +37,9 @@ function authereum(options: {
           name: 'Authereum',
           connect: () => provider.enable(),
           disconnect: () => authereum.logout(),
-          loading: () =>
-            new Promise((resolve: () => void) => {
-              authereum.on('openPopup', resolve)
-            }),
+          loading: new Promise((resolve: () => void) => {
+            authereum.on('openPopup', resolve)
+          }),
           address: {
             get: () => authereum.getAccountAddress()
           },

src/validation.ts

@@ -259,11 +259,9 @@ export function validateModal(modal: WalletCheckModal): never | void {
   validateType({ name: 'modal', value: modal, type: 'object' })
 
   const {
-    img,
     heading,
     description,
     button,
-    invalidMsg,
     eventCode,
     action,
     icon,
@@ -273,28 +271,12 @@ export function validateModal(modal: WalletCheckModal): never | void {
 
   invalidParams(
     otherParams,
-    [
-      'img',
-      'heading',
-      'description',
-      'button',
-      'invalidMsg',
-      'eventCode',
-      'action',
-      'icon'
-    ],
+    ['heading', 'description', 'button', 'eventCode', 'action', 'icon'],
     'modal'
   )
 
-  validateType({ name: 'img', value: img, type: 'string', optional: true })
   validateType({ name: 'heading', value: heading, type: 'string' })
   validateType({ name: 'description', value: description, type: 'string' })
-  validateType({
-    name: 'invalidMsg',
-    value: invalidMsg,
-    type: 'string',
-    optional: true
-  })
   validateType({ name: 'eventCode', value: eventCode, type: 'string' })
   validateType({
     name: 'action',
@@ -306,7 +288,7 @@ export function validateModal(modal: WalletCheckModal): never | void {
   validateType({
     name: 'loading',
     value: loading,
-    type: 'function',
+    type: 'object',
     optional: true
   })
 

src/views/WalletCheck.svelte

@@ -87,7 +87,7 @@
 
         if (activeModal.loading) {
           loading = true
-          activeModal.loading().then(() => (loading = false))
+          activeModal.loading.then(() => (loading = false))
         }
 
         // poll to automatically to check if condition has been met